Repository navigation
Conversation
Author
|
The Actions runs currently report This follow-up was prepared with Codex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route the closed-stream errors in the compression and decompression writers through their existing cleanup labels, releasing the input Py_buffer before returning ValueError. A bytearray can then be resized immediately after the rejected write.
Partially addresses #296: only the two closed-writer input-buffer leaks. Other lifecycle findings in that issue are outside this patch.
Regression coverage: Empty/nonempty mutable inputs and repeated rejected writes; ValueError remains unchanged.
Validation on macOS 26.2 arm64 / CPython 3.12.14:
ZSTD_WARNINGS_AS_ERRORS=1 python setup.py build_ext --inplace.ruff check .,mypy tests/*.py zstandard/*.py, changed-fileruff format --check, andgit diff --checkpass.ruff format --check .reports only an existingsetup.pyindentation issue, reproduced on the untouched base.Linux/Windows, the remaining Python version matrix, and the experimental Rust backend were not run locally.
AI disclosure: Code, tests, and this description were generated with OpenAI Codex and validated with automated local checks. This does not claim human review.