Implement partial patch support for illconfig and catalogconfig. Incl… - #703
Open
kurtnordstrom wants to merge 3 commits into
Open
Implement partial patch support for illconfig and catalogconfig. Incl…#703kurtnordstrom wants to merge 3 commits into
kurtnordstrom wants to merge 3 commits into
Conversation
…ude child branches in cql results
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Directory service’s PATCH semantics for entry configuration sub-resources and adjusts CQL entry searching to include immediate child branches of matched entries, improving both configuration management flexibility and search completeness.
Changes:
- Add CQL expansion so
GET /entries?cql=...returns matched entries plus their direct children (with deduping, ordering, and pagination applied after expansion). - Implement partial/merge PATCH behavior for
illConfig,catalogConfig, andholdingsPolicy(including explicit null/empty handling for deletions/clears where supported). - Extend integration tests to cover nested null semantics, partial creation/merge behavior, and child-including CQL behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| directory/test/entries_test.go | Adds/updates integration tests for partial PATCH merge semantics, null handling, and expanded CQL results including children. |
| directory/query.sql | Adds sqlc queries needed to fetch originals (for merge semantics) and to delete LMS configs by entry. |
| directory/api/entries.go | Implements CQL expansion query wrapper and merges PATCH logic for lmsConfig/catalogConfig/illConfig/holdingsPolicy. |
| directory/api/entries_test.go | Extends unit coverage for the new CQL SQL wrapper generation. |
| directory/api/catalog_config.go | Adds patch validation + recursive merge logic for catalogConfig, and merge helper for holdingsPolicy + illConfig patch merging. |
| directory/api.yaml | Introduces patch schemas (e.g., CatalogConfigPatch) and nullable fields to support explicit null semantics in PATCH. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
kurtnordstrom
marked this pull request as ready for review
August 11, 2026 02:16
kurtnordstrom
requested review from
JanisSaldabols,
adamdickmeiss and
jakub-id
as code owners
August 11, 2026 02:16
jakub-id
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ude child branches in cql results