Repository navigation
Fix reference plan CI expectation for cuDNN attention - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
The reference-plan test expected
draft_attention_executionto be omitted even though its Qwen3 DSpark example explicitly selectscudnn_flex_attention. The planner correctly records that backend as required with runtime evidence still pending, causing the CPU CI run to fail on an outdated expectation.Update the reference-plan contract to assert the requested/resolved cuDNN backend, required capability, and unknown effective execution. Retain the exact omission-set check for the remaining capabilities, and add an explicit SDPA/CP1 case that checks optional, unresolved, omitted attention execution. Production planning behavior and the example configuration are unchanged.
Verification
c7bc9f2bf9829bf186995863083a767610ad609d: lint, compilation, documentation links, 9 source contracts, 537 offline CPU tests, and 16 asset/patch tests. Tests ran on the hosted Linux runner with Python 3.11 and an isolated CPU venv using the unchanged CI dependency setup.git diff --checkpassed.Compatibility and provenance