Conversation
|
the screenshot is just meant to be referred to so you know what to work on, you should refer to figma for actual design implementation, a lot of the sizing is off. for this component specifically i want you to ignore spacing between others as that will be handled elsewhere, only focus on creating this block for the image, name, title, etc. background color will also be handled by the parent. the background color as a placeholder is fine imo but you should confirm with designer. for the image, you should probably take the src in as a prop which you already did. im not sure if ur referring to images in terms of cms or parent component but for cms images will be handled by essentially instead of fetching from public, we will fetch the image from an api so as long as u it accepting the image prop its fine. for parent component, it will map a bunch of the team member card components with a imagesrc included in each object |
austin1im
left a comment
There was a problem hiding this comment.
read da other comment
| .card{ | ||
| width: 320px; | ||
| border-radius: 16px; | ||
| background: var(--off-white); |
| @@ -0,0 +1,63 @@ | |||
| .card{ | |||
| width: 20rem; | |||
There was a problem hiding this comment.
ur width amount is incorrect
There was a problem hiding this comment.
border radius is also not needed here
| display:flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| width:1.8125rem; |
There was a problem hiding this comment.
no need to set height width
| font-weight: 400; | ||
| } | ||
| .department{ | ||
| margin-top: 0.25rem; |
There was a problem hiding this comment.
margin-top amount is wrong
There was a problem hiding this comment.
I don't see notes on figma for this. I even everything out. How about now?
| {image ? ( | ||
| <img src={image} alt={name}/> | ||
| ) : ( | ||
| <div className={styles.placeholder}/> |
There was a problem hiding this comment.
there's a placeholder image now, could u make it display that instead
Make the Team Member Card
Checklist:
after creating your PR please mark all of these:
Notes & Questions for Kyhara and Austin: