Skip to content

Kayla team member card#41

Merged
austin1im merged 16 commits intomainfrom
kayla-team-member-card
Mar 11, 2026
Merged

Kayla team member card#41
austin1im merged 16 commits intomainfrom
kayla-team-member-card

Conversation

@KaylaYuChen
Copy link
Collaborator

@KaylaYuChen KaylaYuChen commented Feb 27, 2026

Make the Team Member Card

Screenshot 2026-02-26 at 11 00 39 PM

Checklist:

after creating your PR please mark all of these:

  • Global colors were used (let us know if any are missing)
  • Text/images/paths are not hard coded (passed in by props)

Notes & Questions for Kyhara and Austin:

  1. I'd like the card to have more space from the edge of the screen so it feels less tight in the layout. I initially tried increasing the border-radius, but that did not change the spacing. Can you guide me on the correct approach for adding more outer spacing?
  2. I had to use this color #e6e6e6 to match the color for the placeholder background. Is there a better color I could use?
  3. I adjusted the border weight and landed on this as a compromise. Please let me know how I could adjust it closer to the example.
  4. I understand that images will eventually be added to the card. Could you provide guidance on best practices for updating the component when real images are used? Should I worry about this after the Team Group is created?

@KaylaYuChen KaylaYuChen linked an issue Feb 27, 2026 that may be closed by this pull request
@austin1im
Copy link
Collaborator

the screenshot is just meant to be referred to so you know what to work on, you should refer to figma for actual design implementation, a lot of the sizing is off. for this component specifically i want you to ignore spacing between others as that will be handled elsewhere, only focus on creating this block for the image, name, title, etc. background color will also be handled by the parent. the background color as a placeholder is fine imo but you should confirm with designer. for the image, you should probably take the src in as a prop which you already did. im not sure if ur referring to images in terms of cms or parent component but for cms images will be handled by essentially instead of fetching from public, we will fetch the image from an api so as long as u it accepting the image prop its fine. for parent component, it will map a bunch of the team member card components with a imagesrc included in each object

Copy link
Collaborator

@austin1im austin1im left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read da other comment

.card{
width: 320px;
border-radius: 16px;
background: var(--off-white);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no px unless image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@KaylaYuChen KaylaYuChen requested a review from austin1im March 6, 2026 01:33
@@ -0,0 +1,63 @@
.card{
width: 20rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ur width amount is incorrect

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

border radius is also not needed here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

display:flex;
align-items: center;
justify-content: center;
width:1.8125rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to set height width

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

font-weight: 400;
}
.department{
margin-top: 0.25rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

margin-top amount is wrong

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see notes on figma for this. I even everything out. How about now?

{image ? (
<img src={image} alt={name}/>
) : (
<div className={styles.placeholder}/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a placeholder image now, could u make it display that instead

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@KaylaYuChen KaylaYuChen requested a review from austin1im March 6, 2026 05:22
@austin1im austin1im merged commit 4674111 into main Mar 11, 2026
@austin1im austin1im deleted the kayla-team-member-card branch March 11, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Team member card

2 participants