Conversation
austin1im
left a comment
austin1im
left a comment
There was a problem hiding this comment.
looks good! just some small changes
| line-height: normal; | ||
| } | ||
|
|
||
| .cardGrid { |
There was a problem hiding this comment.
can you change this name to like .cardsContainer it's more clear imo
|
|
||
| .cardGrid { | ||
| display: flex; | ||
| gap: 1.31rem; |
There was a problem hiding this comment.
instead of setting gap i think it's better in terms of responsiveness to use justify-content: space-between
austin1im
left a comment
austin1im
left a comment
There was a problem hiding this comment.
visually and functionally this works but please clean up ur css
| width: 25rem; | ||
| } | ||
|
|
||
| .cardHeader img { |
There was a problem hiding this comment.
you can nest this in the above component like .cardHeader { ...styling... img { ...styling... } }
| color: var(--off-black); | ||
| font-family: Oxanium; | ||
| font-size: 3rem; | ||
| font-style: normal; |
There was a problem hiding this comment.
you have a lot of unnecessary css, line-height normal font-style normal are all default things, please go back and review what does and doesnt do something and if it doesnt do anything please remove it
| font-weight: 500; | ||
| line-height: normal; | ||
| text-decoration: none; | ||
| } |
There was a problem hiding this comment.
this can be taken down to 8 lines, also the button does not extend across the whole component width
3 participants
Description
breifly describe what you made and take any screenshots or provide anything else you feel is necessary:
created "what we're up to" page
Checklist:
after creating your PR please mark all of these: