Skip to content

Lily current projects#28

Merged
austin1im merged 5 commits intomainfrom
lily-current-projects
Mar 11, 2026
Merged

Lily current projects#28
austin1im merged 5 commits intomainfrom
lily-current-projects

Conversation

@lily848
Copy link
Copy Markdown
Collaborator

@lily848 lily848 commented Feb 13, 2026

Description

breifly describe what you made and take any screenshots or provide anything else you feel is necessary:

made current projects page
Screenshot 2026-02-12 at 4 38 14 PM

Checklist:

after creating your PR please mark all of these:

  • Global colors were used (let us know if any are missing)
  • Text/images/paths are not hard coded (passed in by props)

@lily848 lily848 requested review from austin1im and kyharac February 13, 2026 00:40
@lily848 lily848 self-assigned this Feb 13, 2026
Comment thread app/(pages)/test/page.jsx Outdated
return (
<main className={styles.main}>
<div className={styles.main_title}>
<p>Current Projects</p>
Copy link
Copy Markdown
Collaborator

@austin1im austin1im Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p -> h1 (line 8)

Comment thread app/(pages)/test/page.jsx Outdated
<p>Current Projects</p>
</div>

<div className={styles.container}>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this these cards are structually similar you could make this code a lot shorter by having something like function ProjectCard({imagepath, title, launch, mission, ..., link}) at the top and have 3 <ProjectCard .../>

@@ -0,0 +1,148 @@
.container {
display: flex;
grid-template-columns: 1fr 1fr; /* Two equal columns */
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come u used a grid

margin-bottom: 6.25rem;
padding: 2.5rem 3.125rem;
border-radius: 0.9375rem;
border: 1.5px solid var(--Blue-Gradient, #000138);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for colors refer to _globals/globals.scss and use var(--name)
for example this one should be var(--midnight)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final thing instead of having all the code on page.jsx can u make a folder called _components and then add a folder called something like current-projects and store your work there and have page.jsx import it

web and mobile
@naomitzhao naomitzhao linked an issue Mar 10, 2026 that may be closed by this pull request
@austin1im austin1im merged commit 0c684cb into main Mar 11, 2026
@austin1im austin1im deleted the lily-current-projects branch March 11, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current Projects

2 participants