transpile: Compute and store override_tys ahead of time#1679
Open
Rua wants to merge 16 commits intoimmunant:masterfrom
Open
transpile: Compute and store override_tys ahead of time#1679Rua wants to merge 16 commits intoimmunant:masterfrom
override_tys ahead of time#1679Rua wants to merge 16 commits intoimmunant:masterfrom
Conversation
4154acf to
59262d2
Compare
b387247 to
3351bd8
Compare
e3ecd24 to
733a25f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before proceeding to remove
override_ty, I added a temporary assert to compare the value passed toconvert_exprwith the value being generated by the new method. The assert eventually passed in the full CI suite, which likely means they match perfectly.There was a comment left here concerning this issue:
c2rust/c2rust-transpile/src/translator/mod.rs
Line 4198 in 4887dce
I don't think the cast can be removed, though. In the snapshot test, the
LITERAL_FLOATandNESTED_FLOATmacros switched type fromdoubletofloat, which removed some casts tofloat, but caused new casts todoubleto be added elsewhere.