Skip to content

transpile: Compute and store override_tys ahead of time#1679

Open
Rua wants to merge 16 commits intoimmunant:masterfrom
Rua:override_ty
Open

transpile: Compute and store override_tys ahead of time#1679
Rua wants to merge 16 commits intoimmunant:masterfrom
Rua:override_ty

Conversation

@Rua
Copy link
Contributor

@Rua Rua commented Mar 20, 2026

Before proceeding to remove override_ty, I added a temporary assert to compare the value passed to convert_expr with the value being generated by the new method. The assert eventually passed in the full CI suite, which likely means they match perfectly.

There was a comment left here concerning this issue:

// TODO We'd like to get rid of this cast eventually (see #1321).

I don't think the cast can be removed, though. In the snapshot test, the LITERAL_FLOAT and NESTED_FLOAT macros switched type from double to float, which removed some casts to float, but caused new casts to double to be added elsewhere.

@Rua Rua force-pushed the override_ty branch 5 times, most recently from 4154acf to 59262d2 Compare March 20, 2026 19:06
@Rua Rua force-pushed the override_ty branch 2 times, most recently from b387247 to 3351bd8 Compare March 21, 2026 11:08
@Rua Rua force-pushed the override_ty branch 4 times, most recently from e3ecd24 to 733a25f Compare March 21, 2026 12:37
@Rua Rua marked this pull request as ready for review March 21, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transpile: const macros aren't translated with portable types

1 participant