transpile: Split off various c_ast submodules#1652
Open
Rua wants to merge 7 commits intoimmunant:masterfrom
Open
transpile: Split off various c_ast submodules#1652Rua wants to merge 7 commits intoimmunant:masterfrom
c_ast submodules#1652Rua wants to merge 7 commits intoimmunant:masterfrom
Conversation
kkysen
changed the title
c_ast submodules
kkysen
reviewed
Mar 10, 2026
c2rust-transpile/src/c_ast/mod.rs
Outdated
Comment on lines
35
to
42
Contributor
There was a problem hiding this comment.
It might be useful to keep all of these together. I'm not sure, though.
Contributor
Author
There was a problem hiding this comment.
I don't have a particular stance on it.
| /// If it's not, or we can't tell if it is, return `false`. | ||
| /// | ||
| /// This should be a top-down, pessimistic/conservative analysis. | ||
| pub fn is_const_expr(&self, expr: CExprId) -> bool { |
Contributor
There was a problem hiding this comment.
Previously, related things like fn is_const_expr and fn is_const_stmt were grouped together, but this reorganization breaks that.
Contributor
Author
There was a problem hiding this comment.
Hmm, what do you suggest doing?
Contributor
Author
There was a problem hiding this comment.
I could move all the impl TypedAstContext back into the main module?
Rua
force-pushed
the
ast-refactor2
branch
5 times, most recently
from
2e67657 to
1e909e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.