Push back the jsorbit sample's default transform#13
Merged
zachernuk merged 3 commits intoimmersive-web:mainfrom Mar 27, 2026
Merged
Push back the jsorbit sample's default transform#13zachernuk merged 3 commits intoimmersive-web:mainfrom
zachernuk merged 3 commits intoimmersive-web:mainfrom
Conversation
Pushing back the jsorbit's default transform to avoid clipping with z=0. Note that this sample is intended as a demonstration of the desired interaction, rather than a full specification of the scale and centering intended for Orbit.
Contributor
|
@zachernuk Maybe you can try again, only as of today I'm a member of https://github.com/orgs/immersive-web Thanks! |
Collaborator
Author
|
@mkeblx I think we got you in! |
Contributor
|
Verified fixes clipping ✔️ |
mkeblx
approved these changes
Feb 9, 2026
missing close brace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushing back the jsorbit's default transform to avoid clipping with z=0. Note that this sample is intended as a demonstration of the desired interaction, rather than a full specification of the scale and centering intended for Orbit.
(I still don't seem to be able to set @mkeblx as a reviewer but would love to be able to!)