Repository navigation
Conversation
php_com_locate_typeinfo() stored the default source IID and called ITypeLib_GetTypeInfoOfGuid() on a NULL typelib. The object's IDispatch typeinfo already names that library through GetContainingTypeLib(), including when autoregister_typelib is off. The sink path uses that library and keeps typeinfo NULL when GetTypeInfoOfGuid() fails. A source that is not a dispinterface still raises "Type kind must be dispatchable"; php_com_process_typeinfo() returned true after that error, so com_event_sink() walked an uninitialized name map. Print-false and objects without IProvideClassInfo2 are unchanged. Fixes phpGH-25008
Owner
Author
|
Superseded by php#25020. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_com_locate_typeinfo() stored the default source IID and called ITypeLib_GetTypeInfoOfGuid() with a NULL typelib. The object's IDispatch typeinfo already names that library through GetContainingTypeLib(), including when com.autoregister_typelib is off. The sink path now uses that library and leaves the typeinfo NULL when the GUID lookup fails.
A source that is not a dispinterface still raises "Type kind must be dispatchable". php_com_process_typeinfo() returned true after that error, and com_event_sink() then walked an uninitialized name map. That path now releases the TYPEATTR and returns false, so the sink is not advised. WinHttp IWinHttpRequestEvents is a custom IUnknown interface, so the IDispatch sink does not implement it. com_print_typeinfo() with the sink flag prints that interface. The non-sink print path and objects without IProvideClassInfo2 are unchanged.
Reproduced from phpGH-25008 on the PHP 8.4 x64 NTS CLI, Windows 11, with com.autoregister_typelib=0 and WinHttp.WinHttpRequest.5.1.
Fixes phpGH-25008