[Session] destroy session file without an open descriptor - #273
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
PS_DESTROY_FUNC(files) skipped the unlink when data->fd was -1, so a destroy of a never-opened or already-closed session file returned SUCCESS while the file stayed on disk. The unlink now always runs after the optional ps_files_close(), tolerating ENOENT via the existing access() check. Sibling audit: PS_DESTROY_FUNC(mm) and mod_user have no descriptor gate, and the files close/read/write paths keep their existing descriptor handling.
iliaal
force-pushed
the
fix/session-destroy-closed-fd-84
branch
from
September 10, 2026 22:09
143d796 to
4bfab31
Compare
Owner
Author
|
Upstream: php#23656 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PS_DESTROY_FUNC(files) unlinked the session file only inside the data->fd != -1 branch, so destroying a session whose file was never opened this request or whose descriptor was closed after a failed reopen returned SUCCESS while leaving the file on disk. It now unlinks after ps_files_close() so the key path is always removed; the access() check tolerates a missing file. PS(mm) has no descriptor gate and mod_user delegates to userland. A new test destroys a session from an error handler during session_start() when its mode-0444 file fails to open, failing on unpatched PHP-8.4.