fix: use canonical structure() attribute names#2755
Open
krlmlr wants to merge 1 commit into
Open
Conversation
R-devel deprecates the special structure() arguments .Names, .Dim and .Dimnames, which emit warnings that the test suite escalates. Replace them with the canonical names, dim and dimnames in the affected test fixtures and one plot fixture. structure() maps both spellings to the same attributes, so the constructed objects are identical -- there is no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019E6CUgb5aFw6uvWXztcHgV
1 task
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8ced78f is merged into main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM disclosure: this PR was prepared with Claude Code (Claude Opus 4.8).
What
R-devel deprecates the special
structure()arguments.Names,.Dimand.Dimnames; they emit warnings that the test suite escalates (the ~27 warnings noted on #2749).Replace them with the canonical
names,dimanddimnames.structure()maps both spellings to the same attributes, so the constructed objects are identical — no behavior change.tests/testthat/*.Rfixtures (mostlydput()output) and oneR/plot.common.Rfixture.structure()attribute argument — thelist(...)data and its inner element names are untouched.Scope
Code changes only, branched off
main. The CI/workflow side of the R-devel work lives separately:pakcan resolve dependencies #2753 — disable Bioconductor on old R (via pak'sPKG_USE_BIOCONDUCTOR) sopakresolution stops failing on R 4.2/4.3 where the archivedgraphreleases now 404.claude/**branches #2754 — runR-CMD-checkonclaude/**branches.R_getRegisteredNamespace()so the C23 sanitizer build compiles #2749 — theR_getRegisteredNamespaceC23 sanitizer error, which is a stale CSAN Docker image, not a package bug.🤖 Generated with Claude Code
Generated by Claude Code