refactor: snake_case attr-comb options & arguments, soft-deprecate dotted names#2742
Open
schochastics wants to merge 2 commits into
Open
refactor: snake_case attr-comb options & arguments, soft-deprecate dotted names#2742schochastics wants to merge 2 commits into
schochastics wants to merge 2 commits into
Conversation
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1453158 is merged into feat-attrib_comb:
|
… names Split out from #2676 per review feedback: the renaming of the igraph options and the *.attr.comb function arguments (with soft-deprecation of the dotted names) is carried here so it can be reviewed on its own. - igraph options vertex.attr.comb / edge.attr.comb (and the new graph.attr.comb) are renamed to snake_case *_combine, with back-compatible aliasing in igraph_opt() / igraph_options(); the dotted keys still read and set, soft-deprecated (R/par.R). - simplify() / as_undirected() / contract() gain snake_case edge_attr_combine / vertex_attr_combine arguments via the argument-migration infrastructure (tools/migrations.R); dotted names keep working and soft-deprecate. - union() / intersection() / compose() / disjoint_union() use the snake_case *_combine argument names. - Updates stimulus codegen defaults (types-RR.yaml), regenerated *_impl defaults, and the affected tests/snapshots. Retains the igraph_i_options() ...length() fix from the base branch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
schochastics
force-pushed
the
par-attr-comb-options
branch
from
July 15, 2026 19:10
1453158 to
2f878f3
Compare
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2f878f3 is merged into main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #2676 per review feedback ("I'd like to review the par code in a separate PR"). #2676 now keeps the original dotted option/argument names; this PR carries the naming refactor on its own so it can be reviewed in isolation.
What this does
vertex.attr.comb→vertex_attr_combine,edge.attr.comb→edge_attr_combine, and the newgraph.attr.comb→graph_attr_combine. Reading/setting the old dotted keys still works via back-compatible aliasing inigraph_opt()/igraph_options(), emitting a singlelifecycle::deprecate_soft()warning (R/par.R).simplify(),as_undirected()andcontract()gain snake_caseedge_attr_combine/vertex_attr_combinearguments via the argument-migration infrastructure (tools/migrations.R); the dotted names keep working and soft-deprecate.union()/intersection()/compose()/disjoint_union()use the snake_case*_combineargument names.types-RR.yaml), regenerated*_impldefaults, and the affected tests/snapshots.Base branch
Based on
feat-attrib_comb(notmain) so the diff shows only the renaming. Once #2676 merges, retarget this tomainand the diff collapses to the par changes alone.🤖 Generated with Claude Code