Claude/fix issue 1242 winforms nullref#1247
Merged
GrahamTheCoder merged 3 commits intoicsharpcode:masterfrom Apr 13, 2026
Merged
Claude/fix issue 1242 winforms nullref#1247GrahamTheCoder merged 3 commits intoicsharpcode:masterfrom
GrahamTheCoder merged 3 commits intoicsharpcode:masterfrom
Conversation
…reatePropertyAssignment When InitializeComponent contains a bare identifier assignment (e.g. `Button1 = New Button()` without the `Me.` prefix), s.Left is a VBSyntax.IdentifierNameSyntax. Calling LastOrDefaultDescendant<IdentifierNameSyntax>() on it returns null because DescendantNodes() does not include the node itself, causing a NullReferenceException in CreatePropertyAssignment. Fix: detect when s.Left is itself an IdentifierNameSyntax and use it directly; also add a null guard so other unexpected shapes fall through gracefully. Regression test added based on the Issue774 test but with a bare identifier (no Me.) in InitializeComponent's WithEvents field assignment. https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1242