Open
Conversation
In some Debian environment two of the round trips in to_yaml_spec.rb were failing (those using `.month_of_year` and `day_of_year`. Applying the same fix as the one used in 4bf1718 to fix ice-cube-ruby#483 solved the issue. This patch proposes that corresponding change to `/spec/examples/to_yaml_spec.rb`.
|
This fixes one of the tests for me 👍 Before After Remaining failures: The first test failure is fixed by #528 - but it looks like the second test is still failing 🤔 |
|
Looks like following your pattern for the final remaining test worked for my env 👍 diff --git a/spec/examples/to_yaml_spec.rb b/spec/examples/to_yaml_spec.rb
index 7166110..913cd05 100644
--- a/spec/examples/to_yaml_spec.rb
+++ b/spec/examples/to_yaml_spec.rb
@@ -134,7 +134,7 @@ module IceCube
end
it "should be able to make a round-trip to YAML whilst preserving exception rules" do
- original_schedule = Schedule.new(Time.now)
+ original_schedule = Schedule.new(Time.zone.now)
original_schedule.add_recurrence_rule Rule.daily.day(:monday, :wednesday)
original_schedule.add_exception_rule Rule.daily.day(:wednesday) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some Debian environment two of the round trips in to_yaml_spec.rb were failing (those using
.month_of_yearandday_of_year. Applying the same fix as the one used in 4bf17183be02f8efe17b98c401af40db48a931dc to fix #483 solved the issue.This patch proposes that corresponding change to
/spec/examples/to_yaml_spec.rb.