IBX-11766: Replaced phpunit assertions with webmozart equivalents#1920
Draft
bnowak wants to merge 4 commits into
Draft
IBX-11766: Replaced phpunit assertions with webmozart equivalents#1920bnowak wants to merge 4 commits into
bnowak wants to merge 4 commits into
Conversation
bnowak
force-pushed
the
IBX-11766-replace-phpunit-assertions-with-webmozart-library
branch
from
8dd3186 to
784fd4d
Compare
bnowak
force-pushed
the
IBX-11766-replace-phpunit-assertions-with-webmozart-library
branch
4 times, most recently
from
f1335e9 to
46039ac
Compare
bnowak
force-pushed
the
IBX-11766-replace-phpunit-assertions-with-webmozart-library
branch
from
46039ac to
d68c39b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Related PRs:
ibexa/behat#184
Description:
Installed
webmozart/assertlibrary as require-dev dependency. It's still a bit "hidden" dependency (because behat package use assertions from /src directory), but at least it's defined in this specific library. Previously, phpunit was installed by indirect dependency fromibexa/behatpackage.Replaced phpunit assertions with these from webmozart library.
For QA:
Documentation: