Repository navigation
fix: support positional callbacks in initializePayment - #127
Open
DevMubarak1 wants to merge 1 commit into
Open
DevMubarak1 wants to merge 1 commit into
DevMubarak1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #101.
Context
In
use-paystack.ts,initializePaymentcurrently destructures{ config, onSuccess, onClose }directly from the first argument.The README and earlier versions of this library show callers passing positional arguments:
When called this way,
onSuccessis passed as the first parameter (the options object), and destructuring{ config, onSuccess, onClose }yieldsundefinedfor both callbacks. The payment modal opens, but neither callback ever fires. CallinginitializePayment()without arguments also throws a TypeError when destructuringundefined.What this PR does
(onSuccess, onClose, config).{ config, onSuccess, onClose }.initializePayment()), it handles it cleanly without throwing.InitializePaymenttype inlibs/types.tsso TypeScript users get accurate typing and autocomplete for both patterns.libs/test/use-paystack.test.tsxcovering positional callbacks and zero-argument calls.Both styles work as expected now and existing code using the object syntax won't break.