NAS-142202 / 27.0.0-BETA.1 / Name the API error when the reviewer died before producing output - #10
Merged
Merged
Conversation
A usage-limit 400 killed a file-manager review in 415ms, and the gate answered "produced no structured output — check the review step", sending the reader hunting for a cause the execution log's result entry already stated. When there are no findings, read that entry and put the API error text in the annotation. Still fails closed either way.
AlexKarpov98
approved these changes
Aug 17, 2026
bugclerk
changed the title
Contributor
Contributor
|
This PR has been merged and conversations have been locked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A truenas-file-manager review died in 415ms with zero cost: the org API key had hit its monthly usage limit (
API Error: 400 You have reached your specified API usage limits. You will regain access on 2026-09-01...). The gate's annotation said only "the review produced no structured output — check the review step above", while the execution log's terminal result entry named the cause exactly.Now, when there is no structured output,
check-review-threshold.mjsreads the execution log (newEXECUTION_FILEenv, from the action'sexecution_fileoutput) and, if the reviewer terminated on an API error (terminal_reason: "api_error"/api_error_status), the annotation carries the API's own message and says plainly this is not a finding in the PR.Behavior is otherwise unchanged: fails closed with the existing guidance when the log is missing or shows no API error, and scoring with findings present is untouched (verified on all three paths locally, including a replica of the real failure artifact).