Repository navigation
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
PR Summary by QodoSpeed up settings lookup by comparing encoded names
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper |
|
RAM / Flash usage vs. base commit
See RAM/flash optimization guide for techniques to reduce usage. |
|
Test firmware build ready — commit Download firmware for PR #12237 251 targets built. Find your board's
|
dedfb40 to
bd6b505
Compare
Finding settings by name uses index table and dictionary. Current solution is when configurator ask for settings for example for gps_sat, inav walks through index table and from dictionary create setting name and after stah uses strcmp. It's slow because ibnav have to create setting name for each record in index table.
Correct solution is create index record from name which came from configurator and then just comapre indexes.
The old solution is as slow that even on H7 CPU it makes gaps in dshot frames.
Before
After