Skip to content

Add target ORQAH743WING - #12200

Open
erikOrqa wants to merge 4 commits into
iNavFlight:maintenance-10.xfrom
erikOrqa:new-target-wing
Open

erikOrqa wants to merge 4 commits into
iNavFlight:maintenance-10.xfrom
erikOrqa:new-target-wing

Conversation

@erikOrqa

@erikOrqa erikOrqa commented Nov 3, 2026

Copy link
Copy Markdown

This PR adds a new target for the ORQAH743WING (Orqa H7 WingCore) board.

More info about the board: https://shop.orqafpv.com/products/orqa-h7-wingcore
H7WingCore_3_500x
The sample should be on the way or already delivered!

@qodo-code-review

Copy link
Copy Markdown
Contributor

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Add ORQAH743WING flight-controller target

✨ Enhancement ⚙️ Configuration changes 🕐 40+ Minutes

Grey Divider

AI Description

• Add an STM32H743 target for the Orqa H7 WingCore board.
• Map onboard sensors, buses, serial ports, storage, and PWM outputs to the board hardware.
• Set board defaults for GPS, MSP, PINIO, and PWM beeper operation.
Diagram

graph TD
    Build["H743 build"] --> Board["Board definitions"] --> Devices["Device registry"] --> Sensors["Sensors and OSD"]
    Board --> Timers["Timer mapping"] --> Outputs["PWM and beeper"]
    Board --> Defaults["Board defaults"] --> Ports["Serial and PINIO"]
Loading
High-Level Assessment

A self-contained target follows the repository's existing board-support pattern and avoids coupling this board to another target. Hardware bring-up should verify the declared SPI bus assignments and output mappings.

Files changed (4) +300 / -0

Enhancement (1) +76 / -0
target.cRegister devices and map timer outputs +76/-0

Register devices and map timer outputs

• Registers dual IMUs, OSD, DPS310 barometer addresses, magnetometer options, and an I2C pitot sensor. Maps servo, motor, PWM, and beeper timer channels.

src/main/target/ORQAH743WING/target.c

Other (3) +224 / -0
CMakeLists.txtRegister the ORQAH743WING H743 build target +1/-0

Register the ORQAH743WING H743 build target

• Adds the board to the STM32H743XI target build.

src/main/target/ORQAH743WING/CMakeLists.txt

config.cSet board-specific runtime defaults +44/-0

Set board-specific runtime defaults

• Assigns GPS and MSP functions and baud rates to serial port configurations. Maps four PINIO boxes to user modes and enables PWM beeper mode.

src/main/target/ORQAH743WING/config.c

target.hDefine WingCore hardware and default features +179/-0

Define WingCore hardware and default features

• Declares board identity, peripheral pins and buses, serial receiver, ADC inputs, PINIO, SD-card logging, and default features. Enables dual IMUs, sensors, and up to 14 PWM output ports.

src/main/target/ORQAH743WING/target.h

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. The new target fails to compile ✓ Resolved
Description
Both DPS310 registrations in target.c use DEVHW_DPS310, which is not a defined device
identifier. Building this target reaches those registrations and fails before firmware can be
produced.

2. The second motion sensor is not detected ✓ Resolved
Description
IMU2_SPI_BUS selects SPI2 although the second sensor’s pins are configured for SPI3. Its device
registration consequently probes the OSD bus rather than the configured sensor pins.

3. Digital motor outputs fail to initialize ✓ Resolved

Resolving commit: 75f6535

Resolution reason
The commit reorders the timerHardware table so the four motor outputs (M1-M4) come first, and
changes the S1-S10 servo entries to TIM_USE_SERVO. The first-four automatic DSHOT-capable entries
(S2, S1, S4, S3) that shared DMA variant 0 are no longer TIM_USE_OUTPUT_AUTO, so they can no longer
be allocated as digital motor outputs and no longer collide on the DMA stream. The motor outputs
M1-M4 now occupy the first automatic entries with distinct DMA variants (0, 3, 1, 2). The collision
is removed by changing the allocation, not by assigning new DMA variants as the fix prompt
suggested.
Description
The first four automatic timer entries all select DMA variant zero, assigning their DSHOT channels
the same DMA1 stream. When a mixer allocates multiple digital motors to those entries, the second
channel cannot claim the stream and motor timer initialization fails.

View high (1)
4. Motors drive servo-labeled pads ✓ Resolved

Resolving commit: 75f6535

Resolution reason
Moved M1–M4 timer entries ahead of the S-labeled entries and switched the S1–S10 entries from
TIM_USE_OUTPUT_AUTO to TIM_USE_SERVO, so motor auto-allocation no longer lands on servo pads and
starts at M1.
Description
timerHardware[] places ten S-labeled pads before the M1–M4 pads and gives all of them automatic
motor eligibility. With default timer overrides, motor allocation walks that order, so a motor
configured as the first motor is assigned S2 rather than M1.


Remediation recommended

5. Two pads cannot drive digital motors ✓ Resolved

Resolving commit: 75f6535

Resolution reason
S1–S10 servo pads, including S5 (TIM4 CH4) and S10 (TIM15 CH2), are now declared TIM_USE_SERVO
instead of TIM_USE_OUTPUT_AUTO, so they can no longer be allocated to DSHOT motors.
Description
The S5 and S10 entries use timer channels with no channel-DMA mapping in this target’s
configuration. If either automatic output is allocated to a DSHOT motor, DMA lookup returns no
stream and that motor fails timer initialization.

6. Three enabled barometers go undetected ✓ Resolved
Description
target.h enables BMP280, MS5611 and SPL06, but target.c supplies descriptors only for DPS310
barometers. Because target-specific hardware descriptors suppress the common registrations,
detection of those three enabled sensor types has no device to initialize.

7. Configurator reports truncated board ID ✓ Resolved
Description
TARGET_BOARD_IDENTIFIER is set to the five-character ORH7W, but firmware sends only four bytes
in MSP_BOARD_INFO. When this board connects, inav-configurator parses and logs ORH7 instead;
firmware selection still uses the separate full target name.

Grey Divider

Tip of the day
💡 Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant