* add ADSB areas to GPS map#2569
Open
error414 wants to merge 3 commits intoiNavFlight:maintenance-10.xfrom
Open
* add ADSB areas to GPS map#2569error414 wants to merge 3 commits intoiNavFlight:maintenance-10.xfrom
error414 wants to merge 3 commits intoiNavFlight:maintenance-10.xfrom
Conversation
error414
force-pushed
the
error414/feature/adsb-intercept-calc
branch
from
101344e to
ce1c791
Compare
error414
force-pushed
the
error414/feature/adsb-intercept-calc
branch
3 times, most recently
from
b118ba2 to
f870324
Compare
error414
force-pushed
the
error414/feature/adsb-intercept-calc
branch
from
f870324 to
49de051
Compare
error414
force-pushed
the
error414/feature/adsb-intercept-calc
branch
from
a7cf4ea to
1bf80b2
Compare
Contributor
Review Summary by QodoAdd ADSB warning system and vehicle table to GPS map
WalkthroughsDescription• Add ADSB warning/alert system with distance-based circular zones • Implement ADSB vehicle table displaying all tracked aircraft details • Expand GPS map to full screen with improved layout and styling • Add MSP protocol support for ADSB limits and warning vehicle data • Color-code ADSB table rows for alert/warning/normal/stale states Diagramflowchart LR
A["MSP Protocol<br/>New Codes"] -->|MSP2_ADSB_LIMITS| B["ADSB Limits<br/>Distance Config"]
A -->|MSP2_ADSB_WARNING_VEHICLE_ICAO| C["Warning Vehicle<br/>ICAO Data"]
B --> D["GPS Map<br/>Alert/Warning Circles"]
C --> E["ADSB Vehicle Table<br/>Color-coded Rows"]
D --> F["Enhanced GPS Tab<br/>Full Screen Display"]
E --> F
File Changes1. js/fc.js
|
Contributor
Code Review by Qodo
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+142
to
+170
| [ | ||
| i18n.getMessage('adsbCallsign'), | ||
| 'ICAO', | ||
| i18n.getMessage('gpsLat'), | ||
| i18n.getMessage('gpsLon'), | ||
| i18n.getMessage('adsbAlt'), | ||
| i18n.getMessage('adsbHeading'), | ||
| 'TSLC', | ||
| 'TTL', | ||
| i18n.getMessage('adsbEmitter') | ||
| ].forEach(function(col) { | ||
| $headerRow.append($('<th>').addClass('adsb-table__header').text(col)); | ||
| }); | ||
| $thead.append($headerRow); | ||
| $table.append($thead); | ||
| $table.append($('<tbody>').addClass('adsb-table__body')); | ||
|
|
||
| var $wrapper = $('<div>').addClass('adsb-table__wrapper').append($table); | ||
| $('.adsbVehicleList').empty().append($wrapper); | ||
| } | ||
|
|
||
| var $tbody = $('.adsb-table__body'); | ||
|
|
||
| if (FC.ADSB_VEHICLES.vehicles.length === 0) { | ||
| $tbody.empty(); | ||
| $tbody.append( | ||
| $('<tr>').append( | ||
| $('<td>').attr('colspan', 9).addClass('adsb-table__empty').text('No vehicles') | ||
| ) |
Contributor
There was a problem hiding this comment.
1. icao/tslc headers hardcoded 📘 Rule violation ⚙ Maintainability
The ADSB vehicle table UI introduces multiple user-facing strings as hardcoded literals (e.g., ICAO, TSLC, TTL, No vehicles, —, unit suffixes), bypassing i18next translation keys. This breaks internationalization coverage and violates the project requirement to avoid hardcoded UI text.
Agent Prompt
## Issue description
The ADSB list table renders user-facing strings as hardcoded literals (e.g., `ICAO`, `TSLC`, `TTL`, `No vehicles`, `—`, and unit suffixes like `m`, `°`, `s`) instead of using i18next translation keys.
## Issue Context
Per i18n compliance requirements, all UI-visible text must be localizable via i18next (commonly `data-i18n` in HTML or `i18n.getMessage()` in JS for dynamically created elements).
## Fix Focus Areas
- tabs/gps.js[142-170]
- locale/en/messages.json[6201-6236]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#PR related to iNavFlight/inav#11346
New: