Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the skills directory to the default configuration directories for synchronization, updating the documentation, tests, and path resolution logic. The changes ensure that the skills folder is synced by default and filtered out if manually specified in extraConfigPaths. Feedback was provided to generalize the path filtering logic in src/sync/paths.ts to exclude any default sync item from the extra configuration paths, which would improve maintainability by avoiding hardcoded values.
🤖 Review Jules RelayI found 1 Gemini suggestion so far. Type |
* feat: sync ~/.agents by default with opt-out flags * refactor: rename includeSkills to includeOpencodeSkills
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.config/opencode/skills/by default alongside other config directoriesskillsfromextraConfigPathsso there is a single canonical sync locationTesting
Fixes #40