Skip to content

[PWGLF,PWGMM] Please consider the following formatting changes to #15775 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 2 commits into from
Closed

[PWGLF,PWGMM] Please consider the following formatting changes to #15775 #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f26213
[PWGMM] dndeta-hi: add SD/DD/ND classification and fix linter issues
hyungjun-lee Apr 15, 2026
35776cd
Please consider the following formatting changes
alibuild Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 51 additions & 36 deletions PWGMM/Mult/Tasks/dndeta-hi.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

#include <TH1.h>
#include <TMath.h>
#include <TPDGCode.h>

#include <RtypesCore.h>

Expand Down Expand Up @@ -75,6 +76,9 @@
kDATA = 1,
kINEL,
kINELg0,
kDD,
kSD,
kND,
kECend
};
enum {
Expand Down Expand Up @@ -175,7 +179,8 @@

struct MultiplicityCounter {
SliceCache cache;
Preslice<aod::McParticles> perMCCol = aod::mcparticle::mcCollisionId;
Preslice<Particles> perMCCol = aod::mcparticle::mcCollisionId;
Preslice<FiTracks> perCol = aod::track::collisionId;

Service<o2::framework::O2DatabasePDG> pdg;

Expand Down Expand Up @@ -236,9 +241,9 @@
std::vector<Double_t> logbins(nbins + 1, 0);
Double_t low = 0.01;
Double_t high = 10;
Double_t logbw = (log(high) - log(low)) / nbins;
Double_t logbw = (std::log(high) - std::log(low)) / nbins;
for (int ij = 0; ij <= nbins; ij++) {
logbins[ij] = low * exp(ij * logbw);
logbins[ij] = low * std::exp(ij * logbw);
}
AxisSpec ptbins2 = {logbins, "pT (GeV/c)", "pt bin"};

Expand Down Expand Up @@ -280,12 +285,12 @@
soa::Join<aod::Collisions, aod::EvSels> const& collisions)
{
std::vector<typename std::decay_t<decltype(collisions)>::iterator> cols;
for (auto& bc : bcs) {
for (const auto& bc : bcs) {
if (!useEvSel || (bc.selection_bit(o2::aod::evsel::kIsBBT0A) &&
bc.selection_bit(o2::aod::evsel::kIsBBT0C)) != 0) {
registry.fill(HIST("Selection"), 5.);
cols.clear();
for (auto& collision : collisions) {
for (const auto& collision : collisions) {
if (collision.has_foundBC()) {
if (collision.foundBCId() == bc.globalIndex()) {
cols.emplace_back(collision);
Expand Down Expand Up @@ -314,11 +319,11 @@
FiTracks const& /*tracks*/)
{

for (auto& collision : collisions) {
for (const auto& collision : collisions) {
Bool_1d btrigc(kTrigend, false);
registry.fill(HIST("Selection"), 1.);
auto z = collision.posZ();
auto pertracks = tSample3->sliceByCached(aod::track::collisionId, collision.globalIndex(), cache);
auto pertracks = tSample3->sliceBy(perCol, collision.globalIndex());
auto Ntrk = 0;

// if (collision.selection_bit(aod::evsel::kIsTriggerTVX) && collision.selection_bit(aod::evsel::kNoTimeFrameBorder) && collision.selection_bit(aod::evsel::kNoITSROFrameBorder)) {
Expand All @@ -326,14 +331,14 @@
if (collision.sel8()) {
btrigc[kSel8] = true;
registry.fill(HIST("Selection"), 2.);
if (std::abs(z) < 10) {

Check failure on line 334 in PWGMM/Mult/Tasks/dndeta-hi.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
registry.fill(HIST("Selection"), 3.);
}
}
if (btrigc[kSel8] && std::abs(z) < 10)

Check failure on line 338 in PWGMM/Mult/Tasks/dndeta-hi.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
registry.fill(HIST("hft0multiplicity"), collision.multFT0C());

for (auto& track : pertracks) {
for (const auto& track : pertracks) {
[[maybe_unused]] int dummy = track.globalIndex();
if (std::abs(track.eta()) < 1)
Ntrk++; // charged track check
Expand All @@ -357,12 +362,12 @@
}

if (IsPbPb) {
if (std::abs(z) < 10 && btrigc[kSel8])

Check failure on line 365 in PWGMM/Mult/Tasks/dndeta-hi.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
registry.fill(HIST("hcentrality"), cent);
} else {
if (std::abs(z) < 10 && btrigc[kSel8g0])

Check failure on line 368 in PWGMM/Mult/Tasks/dndeta-hi.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
registry.fill(HIST("hcentrality"), cent);
if (std::abs(z) < 10 && btrigc[kSel8g0])

Check failure on line 370 in PWGMM/Mult/Tasks/dndeta-hi.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
registry.fill(HIST("hcentralityvscentraldndeta"), cent, Ntrk);
}
for (auto itrigc = 1u; itrigc < kTrigend; itrigc++) {
Expand All @@ -370,8 +375,8 @@
registry.fill(HIST("hreczvtx"), Double_t(kDATA), Double_t(itrigc), z, cent);
}

for (auto& track : pertracks) {
for (const auto& track : pertracks) {
if (btrigc[kSel8] && std::abs(track.eta()) < 0.8 && std::abs(z) < 10)

Check failure on line 379 in PWGMM/Mult/Tasks/dndeta-hi.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
registry.fill(HIST("hrecdndpt"), track.pt());
if (btrigc[kSel8])
registry.fill(HIST("recetaINELg0Sel8recz10"), track.eta(), z);
Expand All @@ -388,26 +393,36 @@

PresliceUnsorted<soa::Join<MyCollisions, aod::McCollisionLabels>> perMcCol = o2::aod::mccollisionlabel::mcCollisionId;
Preslice<aod::McParticles> perMCColparticles = aod::mcparticle::mcCollisionId;
Preslice<FiLTracks> perColFiLTracks = aod::track::collisionId;
using MCex = soa::Join<aod::McCollisions, aod::HepMCXSections>;
void processMCCounting(
aod::McCollisions const& mcCollisions, soa::Join<MyCollisionsCent, aod::McCollisionLabels> const& collisions, Particles const& mcParticles,
MCex const& mcCollisions, soa::Join<MyCollisionsCent, aod::McCollisionLabels> const& collisions, Particles const& mcParticles,
FiLTracks const& tracks)
{
for (auto& mcCollision : mcCollisions) {
for (const auto& mcCollision : mcCollisions) {
Bool_1d bevtc(kECend, false);
bevtc[kINEL] = true;
auto procId = mcCollision.processId();
if (procId == 101) {

Check failure on line 406 in PWGMM/Mult/Tasks/dndeta-hi.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
bevtc[kND] = true;
} else if (procId == 103 || procId == 104) {

Check failure on line 408 in PWGMM/Mult/Tasks/dndeta-hi.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
bevtc[kSD] = true;
} else if (procId == 105 || procId == 106) {

Check failure on line 410 in PWGMM/Mult/Tasks/dndeta-hi.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
bevtc[kDD] = true;
}
registry.fill(HIST("Selection"), 1.);

auto mcz = mcCollision.posZ();
auto genz = mcz;

auto Ntrk_gen = 0;
auto particles = mcParticles.sliceByCached(aod::mcparticle::mcCollisionId, mcCollision.globalIndex(), cache);
for (auto& particle : particles) {
for (const auto& particle : particles) {
if (!particle.isPhysicalPrimary())
continue;
auto kp = pdg->GetParticle(particle.pdgCode());
if (kp != nullptr) {
if (std::abs(kp->Charge()) >= 3) {

Check failure on line 425 in PWGMM/Mult/Tasks/dndeta-hi.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (std::abs(particle.eta()) < 1) {
Ntrk_gen++;
}
Expand All @@ -426,7 +441,7 @@
registry.fill(HIST("Selection"), 10);
if (bevtc[kINELg0] && std::abs(mcz) < 10)
registry.fill(HIST("Selection"), 12);
for (auto& particle : particles) {
for (const auto& particle : particles) {
if (!particle.isPhysicalPrimary())
continue;
auto kp = pdg->GetParticle(particle.pdgCode());
Expand All @@ -452,7 +467,7 @@
if (collisionsample.size() != 1) {
cent = -1.0;
} else {
for (auto& collision : collisionsample) {
for (const auto& collision : collisionsample) {
if (IsPbPb) {
if constexpr (MyCollisionsCent::template contains<aod::CentFT0Cs>())
cent = collision.centFT0C();
Expand All @@ -462,7 +477,7 @@

// auto Ntrk_rec = 0;
// auto trackspart = tracks.sliceByCached(aod::track::collisionId, collision.globalIndex(), cache);
// for (auto& track : trackspart) {
// for (const auto& track : trackspart) {
// if (std::abs(track.eta()) < 1) {
// Ntrk_rec++;
// }
Expand All @@ -476,9 +491,9 @@
}
Int_t pid = 0;
std::vector<Double_t> particleetas;
for (auto& particle : particles) {
for (const auto& particle : particles) {
auto p = pdg->GetParticle(particle.pdgCode());
if (std::abs(particle.pdgCode()) == 310 && std::abs(particle.eta()) < 0.5 && std::abs(genz) < 10)
if (std::abs(particle.pdgCode()) == kK0Short && std::abs(particle.eta()) < 0.5 && std::abs(genz) < 10)
registry.fill(HIST("Selection"), 17.);
if (!particle.isPhysicalPrimary()) {
continue;
Expand Down Expand Up @@ -519,7 +534,7 @@
}
}

for (auto& collision : collisionsample) {
for (const auto& collision : collisionsample) {
auto cent = -1.f;
if (IsPbPb) {
if constexpr (MyCollisionsCent::template contains<aod::CentFT0Cs>())
Expand All @@ -529,7 +544,7 @@
cent = collision.centFT0M();
// auto Ntrk_rec = 0;
// auto trackspart = tracks.sliceByCached(aod::track::collisionId, collision.globalIndex(), cache);
// for (auto& track : trackspart) {
// for (const auto& track : trackspart) {
// if (std::abs(track.eta()) < 1) {
// Ntrk_rec++;
// }
Expand All @@ -550,23 +565,23 @@
if (bevtc[kINEL] && btrigc[kSel8] && std::abs(z) < 10)
registry.fill(HIST("hft0multiplicity"), collision.multFT0C());
if (collisionsample.size() == 1 && bevtc[kINELg0] && btrigc[kSel8]) {
for (auto eta : particleetas) {
for (const auto& eta : particleetas) {
registry.fill(HIST("genetaINELg0Sel8recz10"), eta, z);
registry.fill(HIST("genetaINELg0Sel8genz10"), eta, mcz);
}
registry.fill(HIST("reczINELg0Sel8"), z);
registry.fill(HIST("genzINELg0Sel8"), genz);
}
if (collisionsample.size() == 1 && bevtc[kINELg0]) {
for (auto eta : particleetas) {
for (const auto& eta : particleetas) {
registry.fill(HIST("genetaINELg0genz10"), eta, mcz);
}
registry.fill(HIST("genzINELg0"), genz);
}

auto Ntrk_rec = 0;
auto trackspart = tracks.sliceByCached(aod::track::collisionId, collision.globalIndex(), cache);
for (auto& track : trackspart) {
auto trackspart = tracks.sliceBy(perColFiLTracks, collision.globalIndex());
for (const auto& track : trackspart) {
if (std::abs(track.eta()) < 1) {
Ntrk_rec++;
}
Expand Down Expand Up @@ -601,7 +616,7 @@
}
}
std::vector<Int_t> mclabels;
for (auto& track : trackspart) {
for (const auto& track : trackspart) {
if (track.has_mcParticle()) {
Int_t pid = kBkg;
auto particle = track.template mcParticle_as<Particles>();
Expand All @@ -626,7 +641,7 @@
for (auto MotherIDs = particle.mothersIds().front(); MotherIDs <= particle.mothersIds().back(); MotherIDs++) {
auto mother = mcParticles.rawIteratorAt(MotherIDs);
auto pdg_mother = mother.pdgCode();
if (pdg_mother == 310 || std::abs(pdg_mother) == 3122) {
if (pdg_mother == kK0Short || std::abs(pdg_mother) == kLambda0) {
pid = kMotherStrange;
}
}
Expand Down Expand Up @@ -677,7 +692,7 @@
}

auto mcCollision = collision.mcCollision();
auto particlesPerCol = particles.sliceByCached(aod::mcparticle::mcCollisionId, mcCollision.globalIndex(), cache);
auto particlesPerCol = particles.sliceBy(perMCCol, mcCollision.globalIndex());
}

PROCESS_SWITCH(MultiplicityCounter, processTrackEfficiencyGeneral, "MC Count tracks", false);
Expand All @@ -697,7 +712,7 @@
auto genz = mcCollision.posZ();
Bool_1d bevtc(kECend, false);
bevtc[kINEL] = true;
for (auto& particle : mcParticles) {
for (const auto& particle : mcParticles) {
if (!particle.isPhysicalPrimary())
continue;
auto p = pdg->GetParticle(particle.pdgCode());
Expand All @@ -713,9 +728,9 @@
registry.fill(HIST("hgenzvtx"), Double_t(ievtc), genz, -1.0);
}
Int_t pid = 0;
for (auto& particle : mcParticles) {
for (const auto& particle : mcParticles) {
auto p = pdg->GetParticle(particle.pdgCode());
if (std::abs(particle.pdgCode()) == 310 && std::abs(particle.eta()) < 0.5 && std::abs(genz) < 10)
if (std::abs(particle.pdgCode()) == kK0Short && std::abs(particle.eta()) < 0.5 && std::abs(genz) < 10)
registry.fill(HIST("Selection"), 17.);
if (!particle.isPhysicalPrimary()) {
continue;
Expand Down Expand Up @@ -762,7 +777,7 @@
FiTracks const& /*tracks*/,
DaughterTracks const& /*Dautrks*/)
{
for (auto& collision : collisions) {
for (const auto& collision : collisions) {
if (!collision.sel8())
continue;
auto z = collision.posZ();
Expand All @@ -777,7 +792,7 @@
}

auto v0s_per_coll = fullV0s.sliceBy(perCollisionV0, collision.globalIndex());
for (auto& v0 : v0s_per_coll) {
for (const auto& v0 : v0s_per_coll) {

auto pTrack = v0.template posTrack_as<DaughterTracks>();
auto nTrack = v0.template negTrack_as<DaughterTracks>();
Expand All @@ -790,12 +805,12 @@
continue;
if (v0.v0cosPA() < v0cospa)
continue;
if (fabs(pTrack.eta()) > 0.9)
if (std::fabs(pTrack.eta()) > 0.9)
continue;
if (fabs(nTrack.eta()) > 0.9)
if (std::fabs(nTrack.eta()) > 0.9)
continue;

if (fabs(v0.eta()) < 0.5)
if (std::fabs(v0.eta()) < 0.5)
registry.fill(HIST("hv0k0s"), v0.mK0Short());
registry.fill(HIST("hv0mass"), cent, Double_t(kK0short), v0.eta(), Double_t(v0.mK0Short()));
registry.fill(HIST("hv0mass"), cent, Double_t(kLambda), v0.eta(), Double_t(v0.mLambda()));
Expand All @@ -814,7 +829,7 @@
soa::Filtered<LabeledTracksEx> const& /*tracks*/,
DaughterTracks const& /*Dautrks*/)
{
for (auto& collision : collisions) {
for (const auto& collision : collisions) {
auto cent = -1.f;

if (IsPbPb) {
Expand All @@ -830,7 +845,7 @@
if (!collision.has_mcCollision()) // check mc particle
continue;

for (auto& v0 : fullV0s) {
for (const auto& v0 : fullV0s) {

auto pTrack = v0.template posTrack_as<DaughterTracks>();
auto nTrack = v0.template negTrack_as<DaughterTracks>();
Expand Down
Loading