-
-
Notifications
You must be signed in to change notification settings - Fork 17
Sync Sanctum, Socialite, Horizon and Reverb updates and port Sentinel #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
87ad01f
4416561
f4ad812
9228d8c
f11b388
f3415f1
f76f822
89576c2
b59f013
dd3bec8
6a47739
9e12a68
644e5dd
b405233
8035b6c
ddaf62b
d426d58
e159198
a34297e
671c15d
b02eeef
7f55762
1c22da5
fa2e0bc
b2871d0
ceabc54
299e376
5effd32
fb87c71
149b1fb
c73c44b
f09d44e
3596e9d
aec987b
6b899a1
a6d24d0
7260133
b4c874b
6baa183
478bce5
cea845e
e553fd2
8229cfd
2ae0511
fe8770d
ac5eba3
6c50e91
7700e48
ae6fe7e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -146,10 +146,10 @@ return [ | |
| 'max_message_size' => (int) env('REVERB_APP_MAX_MESSAGE_SIZE', 10_000), | ||
| 'accept_client_events_from' => env('REVERB_APP_ACCEPT_CLIENT_EVENTS_FROM', 'members'), | ||
| 'rate_limiting' => [ | ||
| 'enabled' => (bool) env('REVERB_APP_RATE_LIMIT_ENABLED', false), | ||
| 'enabled' => (bool) env('REVERB_APP_RATE_LIMITING_ENABLED', false), | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Preserve the previous rate-limit environment names or document the breaking migration; existing deployments using either old name silently disable rate limiting or limit termination. Prompt for AI agents
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are the names laravel/reverb introduced in PR 371, and the docs now match them, so Reverb settings from a Laravel app work as written. The older names were a Hypervel rename that never shipped in a release, so there's no migration to document. |
||
| 'max_attempts' => (int) env('REVERB_APP_RATE_LIMIT_MAX_ATTEMPTS', 60), | ||
| 'decay_seconds' => (int) env('REVERB_APP_RATE_LIMIT_DECAY_SECONDS', 60), | ||
| 'terminate_on_limit' => (bool) env('REVERB_APP_RATE_LIMIT_TERMINATE_ON_LIMIT', false), | ||
| 'terminate_on_limit' => (bool) env('REVERB_APP_RATE_LIMIT_TERMINATE', false), | ||
| ], | ||
| ], | ||
| ], | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1 @@ | ||
| /vendor | ||
| /laravel | ||
| /node_modules | ||
| /phpunit.xml | ||
| composer.lock | ||
| .phpunit.result.cache | ||
| .phpunit.cache/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium
.php-cs-fixer.php:113composer lintchecks the installeddogfood/testbench-package/vendorfiles, andlint:fixcan rewrite third-party code there.exclude('vendor')only excludes the root-relative directory, so keep the nested vendor exclusion alongsidenode_modules.🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finder already skips that directory. When it searches recursively,
exclude()with a name that has no slash rejects every directory with that name at any depth, not just the one at the root (see Symfony'sExcludeDirectoryFilterIterator). With this config,php-cs-fixer list-fileslists none of the files underdogfood/testbench-package/vendor, so the extra entry was redundant.