style: apply cargo fmt to unblock test job#27
Merged
Conversation
Formatting changes that `cargo fmt --check` was failing on under the test job, blocking every Dependabot PR. Replays the exact output of rustfmt as captured from the failing CI log; no semantic changes. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Formatting changes that `cargo fmt --check` was failing on under the test job, blocking every Dependabot PR. Replays the exact output of rustfmt as captured from the failing CI log; no semantic changes. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
cargo fmt --checkis failing in thetestjob ofrust-ci.yml, which blocks every Dependabot PR. RUSTFLAGS=-Dwarnings + fmt-check-strict means the workflow rejects any unformatted code.What
Replays the exact rustfmt output captured from the failing CI log on PR #22. Five reformats:
src/lib.rs:77—ImagePair::new()signature wrappedsrc/lib.rs:138—partition_pairs()signature + return tuple wrappedtests/smoke_test.rs:75—assert_eq!()wrappedtests/smoke_test.rs:213—matches!()wrappedtests/smoke_test.rs:236—.map(|i| ImagePair::new(...))wrapped to multi-line blockNo semantic changes; only whitespace.
Verify
The test job's
cargo fmt --checkstep should now pass. If rustfmt picks up any additional whitespace differences I missed, CI will tell us and we iterate.