Skip to content

fix(ci): adopt the template's inline hypatia-scan.yml - #35

Merged
hyperpolymath merged 2 commits into
mainfrom
marina/optimistic-cray-js64k7
Nov 10, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
marina/optimistic-cray-js64k7

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Estate Rules is red on main (run 42879373951) at the verdict-grid lane suite: FAIL: cannot locate Hypatia path conversion.

tests/workflows/workflow_evidence_test.sh comes from the template. It reads the inline jq --arg ws "$GITHUB_WORKSPACE/" step that makes Hypatia's finding paths repo-relative. This repository had kept a one-job caller of metadatastician/standards/.github/workflows/hypatia-scan-reusable.yml, so the step was not there. The mint failure earlier in the same job hid this until #28.

As the owner chose, this PR adopts the template's inline workflow.

Changes

  • .github/workflows/hypatia-scan.yml: now rsr-template-repo main (0208563) byte for byte.
    • It builds the same Hypatia pin as before (be98f74).
    • It uploads the SARIF (category hypatia) and the hypatia-scan-findings artifact that fork-governance.yml and verdict-grid-publish.yml already read.
    • It fails on any critical finding.
    • The other workflows and .github/workflows/README.adoc already describe this inline job.
  • .github/workflows/actions.lock: the hypatia-scan.yml entry is the template lock's entry for the same file. Every dependency record it names was already in this lock. The standards@46ee183 record stays for its other users.

RSR Quality Checklist

Required

  • Tests pass (see Testing)
  • Code is formatted: the workflow is the template's file unchanged
  • Linter is clean
  • No banned language patterns
  • No unsafe blocks without // SAFETY: comments
  • No banned functions
  • SPDX license headers present
  • No secrets, credentials, or .env files included

As Applicable

  • None applies.

Testing

Run locally on this branch:

  • scripts/check-lock-sync.sh: pass (0 dangling edges, every workflow has a lock key).
  • standards scripts/close-lock.sh --check .github/workflows at d3e4b48: closed, no dangling edges.
  • tests/workflows/workflow_evidence_test.sh: pass (it failed with the old caller).
  • scripts/check-workflow-edges.sh: all workflow edges resolve.
  • tests/workflows/check_lock_sync_test.sh and tests/workflows/governance_policy_test.sh: pass.

The lock entry was copied from the template's tool-written lock for the same file, not generated here: this session has no gh actions-lock. Lock Sync Gate and Actions lockfile verify in CI are the authority on it.

Hosted proof of the scan itself comes from this PR's Hypatia Security Scan run.

Screenshots

Not applicable.


Generated by Claude Code

Estate Rules is red on main at the verdict-grid lane suite:
"cannot locate Hypatia path conversion". The suite's
tests/workflows/workflow_evidence_test.sh comes from the template and
reads the inline jq step that makes finding paths repo-relative. This
repository had kept a one-job caller of the standards reusable
workflow, so the step was not there. The mint failure earlier in the
same job hid this until #28.

hypatia-scan.yml is now rsr-template-repo main (0208563) byte for byte.
It builds the same Hypatia pin as before (be98f74), uploads the SARIF
and the hypatia-scan-findings artifact that fork-governance.yml and
verdict-grid-publish.yml already read, and gates on zero critical
findings. The other workflows and .github/workflows/README.adoc already
describe this inline job.

actions.lock: the hypatia-scan.yml entry is the template lock's entry
for the same file; every dependency record it names was already in
this lock, and the standards@46ee183 record stays for its other users.

Checked locally: scripts/check-lock-sync.sh, standards close-lock.sh
--check (closed, no dangling edges), tests/workflows/
workflow_evidence_test.sh, scripts/check-workflow-edges.sh,
check_lock_sync_test.sh and governance_policy_test.sh all pass.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6
Signed-off-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🟠 indeterminate · the verdict grid could not be rendered · 7eac2309a6e7

The renderer pinned in metadatastician/standards@8e48b1caade0 was missing or did not match its recorded sha256.

Orange means the evidence for this lane was unavailable, not that the repository passed.

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 10, 2026 19:23
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Repository owner deleted a comment from coderabbitai Bot Nov 10, 2026
@hyperpolymath
hyperpolymath merged commit 249715d into main Nov 10, 2026
69 of 70 checks passed
@hyperpolymath
hyperpolymath deleted the marina/optimistic-cray-js64k7 branch November 10, 2026 19:24
@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants