Skip to content

ci: check pin drift before requiring a write credential - #111

Open
hyperpolymath wants to merge 1 commit into
mainfrom
fix/tracker-read-before-write
Open

hyperpolymath wants to merge 1 commit into
mainfrom
fix/tracker-read-before-write

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Use a read-only repository token for discovery. Current pins succeed without an automation credential. Stale pins still fail explicitly if the PR cannot be proposed. Source incident: plasma-parser-writer run 41406469327.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7d5cf280-846f-4488-96a4-7409a584826f
Commits

Reviewing files that changed from the base of the PR and between d6d1594 and 277c652.

Files selected for processing: 1
  • .github/workflows/track-estate-audit.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 3
  • GitHub Check: rust-ci / Rust CI verdict
  • GitHub Check: CodeRabbit
  • GitHub Check: semgrep-cloud-platform/scan
Summary

Summary by CodeRabbit

  • Chores
    • The automated estate audit now uses read-only repository access when no updates are needed. If updates are required, it checks for write access before proceeding.
    • No changes to end-user features or application behaviour.

The estate audit workflow now uses read-only job permissions and checks for an automation token only after it finds stale pins. It uses that token for branch and pull request operations.

Changes: Estate audit token handling

Layer / File(s) Summary
Conditional write token handling
.github/workflows/track-estate-audit.yml
The job-level permissions are limited to contents: read. The update step receives GITHUB_TOKEN and AUTOMATION_TOKEN separately. If stale pins need updating, the script requires WRITE_TOKEN and exports it as GH_TOKEN; otherwise, it exits before the token check.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to 277c6

No actionable merge-blocking risk was identified in the token-handling changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: the workflow checks pin drift before it requires a write credential.
Description check Passed The description is directly related to the changes. It explains read-only discovery, the condition for requiring an automation credential, and the failure behaviour for stale pins.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T07:33:08.774004Z 277c652 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant