Skip to content

Fix/token permissions id 20260911 - #25

Open
hyperpolymath wants to merge 3 commits into
mainfrom
fix/token-permissions-id-20260911
Open

Fix/token permissions id 20260911#25
hyperpolymath wants to merge 3 commits into
mainfrom
fix/token-permissions-id-20260911

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Closes #

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (would change existing behaviour)
  • 🕳️ Soundness fix (fixes a checker/proof false-negative)
  • 📖 Documentation
  • 🧹 Refactor / tech debt (behaviour-preserving)
  • ⚡ Performance
  • 🔧 Build / CI / tooling

How has this been verified?

Checklist

  • My commits are signed (git commit -S).
  • I ran the project's own checks/tests locally and they pass.
  • New files carry the correct SPDX-License-Identifier (code/config MPL-2.0,
    prose CC-BY-SA-4.0); I did not relicense existing files.
  • Docs are updated, and no public claim now overstates what the code does.
  • I have not introduced a soundness hole (or I have flagged where I might have).

Notes for reviewers

hyperpolymath and others added 3 commits August 5, 2026 10:28
…the rest

Estate top-up pass. Three separate things, none of which invents a value.

FILLED — every token with a single mechanical answer: OWNER, REPO, FORGE,
PROJECT, PACKAGE_NAME, PROJECT_NAME, AUTHOR, AUTHOR_EMAIL, CONDUCT_EMAIL,
AUTHOR_FIRST/LAST/INITIALS, CURRENT_YEAR, CURRENT_DATE, DATE, MAIN_BRANCH.
Identity comes from the git remote, dates from the clock, project name from the
README H1 where there is one.

Deliberately NOT filled, because more than one defensible answer exists and a
confident wrong value is worse than a visible gap: SECURITY_EMAIL (two competing
addresses are in use across the estate), RESPONSE_TIME, CONDUCT_TEAM (which
substitutes into "a {{CONDUCT_TEAM}} member", not English), WEBSITE,
PROJECT_DESCRIPTION, LANG_STACK.

DELETED — ARCHITECTURE.md, where it is byte-identical to the 346-copy estate
boilerplate (blob 607e3d8). Those 33 lines describe a src/ tests/ docs/
scripts/ config/ tree that this repo does not have, so the file is not merely
uninformative, it is wrong. Genuinely written ARCHITECTURE files are matched by
hash and left alone. No file beats a confidently false one.

CODEOWNERS — rewritten to the solo form mandated by
hyperpolymath/standards CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all
line where the only owner is the sole maintainer. The estate's own
templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and
resolves standards#55, so it wins. Files naming a genuine co-owner are Rule 2
and are untouched. Note @hyperpolymath and @metadatastician are the same person,
so a file naming the other account is a copy artifact that silently routed
review requests to the wrong account.

SURFACED — REQUIRES_INITIALISATION.md, and a priority action in
0-AI-MANIFEST.a2ml. Tokens that need a decision no script can make are left
visibly unfilled rather than faked or quietly deleted. The marker says what each
one is, which files it belongs in, why it was not done already, and that it must
be deleted only once the work is genuinely finished.
Apply principle of least privilege for GITHUB_TOKEN:
- Change top-level permissions to read-only
- Jobs inherit read permissions, can escalate as needed

This resolves Scorecard TokenPermissionsID alerts.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 79b84553-bcdd-482d-8de6-a972dbb9d47e

📥 Commits

Reviewing files that changed from the base of the PR and between d301571 and 759469a.

📒 Files selected for processing (5)
  • .github/CODEOWNERS
  • .github/workflows/lean-build.yml
  • 0-AI-MANIFEST.a2ml
  • CODE_OF_CONDUCT.md
  • REQUIRES_INITIALISATION.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
🔇 Additional comments (4)
.github/workflows/lean-build.yml (1)

26-26: LGTM!

Also applies to: 54-55, 59-59

.github/CODEOWNERS (1)

1-4: LGTM!

REQUIRES_INITIALISATION.md (1)

1-78: LGTM!

CODE_OF_CONDUCT.md (1)

11-11: LGTM!

Also applies to: 139-139, 234-234, 314-314


📝 Summary

Summary by CodeRabbit

  • Documentation

    • Added repository initialisation guidance covering outstanding configuration placeholders and their resolution.
    • Updated the Code of Conduct with a designated contact address and clarified reporting and appeals references.
  • Chores

    • Updated repository ownership policy documentation.
    • Improved build validation so test configuration issues and test failures now fail automated checks consistently.
    • Added clearer repository setup notices for incomplete configuration.

Walkthrough

The pull request updates repository ownership metadata, documents required initialisation, replaces conduct email placeholders, and changes the Lean workflow to fail on any unsuccessful test command.

Changes

Repository maintenance

Layer / File(s) Summary
Initialisation and contact contracts
0-AI-MANIFEST.a2ml, REQUIRES_INITIALISATION.md, CODE_OF_CONDUCT.md
The repository documents four unresolved substitution tokens. The Code of Conduct now uses the concrete conduct email address in four locations.
Ownership policy
.github/CODEOWNERS
The wildcard and path-specific ownership entries were removed. SPDX attribution and solo-maintainer comments were added.
Lean test enforcement
.github/workflows/lean-build.yml
The workflow quotes GITHUB_PATH. The Lean test step now fails for every non-zero lake test result, including the no-driver case.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 75946

No actionable merge-blocking risk remains in the reviewed changes.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains the standard template but does not state what the pull request changes, why it changes it, or how it was verified. Replace the empty template sections with a concise summary of the token-permission changes, placeholder handling, CODEOWNERS updates, and verification results. Select the applicable change type and complete the checklist where relevant.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the token-permission change, which is a main objective of the pull request. The date-like identifier adds noise, but the title remains related and understandable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch fix/token-permissions-id-20260911

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the test-run light
And keeps the setup notes in sight
The owners rest in SPDX care
Clear conduct contacts now sit there
No-driver failures stop the night

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) September 12, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants