Skip to content

fix(gsbot): bump three locked deps past blocking RUSTSEC advisories - #624

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/vigilant-turing-94eajv-gsbot-lock
Oct 27, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/vigilant-turing-94eajv-gsbot-lock

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

GSBot build, tests and dependency security fails on main and on every PR (#622, #623) because of three blocking advisories. This is a lockfile-only fix in bots/gsbot/Cargo.lock, and every update is semver-compatible:

Crate From To Advisory
webpki-roots 1.0.7 1.0.11 RUSTSEC-2026-0381 (fixed in ≥ 1.0.10)
rustls-webpki 0.103.15 0.103.16 RUSTSEC-2026-0382: distrusted intermediates can be accepted
tokio 1.52.3 1.54.1 RUSTSEC-2026-0386: AsyncFd I/O safety; no fixed 1.52.x release exists

This corrects the fix I proposed on #622. That proposal named only webpki-roots, and running the check showed that bump alone still fails on the other two.

Validation

  • Ran the CI step with cargo-deny 0.20.2, the version CI pins: cargo deny --locked --config deny.toml check advisories --warn unmaintained.
    • On main's lock it reports advisories FAILED (0381, 0382, 0386).
    • On this lock it reports advisories ok. derivative remains as an unmaintained warning, which is what deny.toml intends.
  • cargo test --locked --all-targets passes.

Generated by Claude Code

The gsbot job's `cargo deny check advisories` failed on main and on
every PR. Lockfile-only, semver-compatible updates:

- webpki-roots 1.0.7 -> 1.0.11   (RUSTSEC-2026-0381, needs >= 1.0.10)
- rustls-webpki 0.103.15 -> 0.103.16 (RUSTSEC-2026-0382, distrusted
  intermediates accepted)
- tokio 1.52.3 -> 1.54.1         (RUSTSEC-2026-0386, AsyncFd I/O safety;
  1.52.x has no fixed release)

Reproduced with cargo-deny 0.20.2 (the CI pin): FAILED on main's lock,
"advisories ok" after (derivative stays a --warn unmaintained warning,
as deny.toml intends). `cargo test --locked --all-targets` passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PpQVLrCbURpoXtrdvy8V3B
@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Copy link
Copy Markdown
Owner Author

build · test · clippy (rhodibot) fails here on canon pin drift. That failure is red on main as well, and this diff touches only bots/gsbot/Cargo.lock. #625 fixes it. I kept the two fixes in separate PRs, at the owner's choice, rather than porting that one in. The gsbot check is the one this PR should turn green.


Generated by Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T04:46:25.662951Z b3115bf Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath merged commit aed110a into main Oct 27, 2026
30 of 31 checks passed
@hyperpolymath
hyperpolymath deleted the claude/vigilant-turing-94eajv-gsbot-lock branch October 27, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants