Rust hygiene: 29 expect_in_hot_path findings across bots/* #255

Activity

1. hyperpolymath commented on Jun 20, 2026

   

   hyperpolymath

   on Jun 20, 2026 – with Claude

   OwnerAuthor

   More actions

   Grounded against main (f39d3d5), post sustainabot→oikosbot extraction (#297)

   Re-checked after #297/#298 emptied the bots/sustainabot/ slot — this issue survived the extraction and is still valid. The two named targets (accessibilitybot, cipherbot) are untouched; only sustainabot's vendored crates were removed, so the count is now ≤29 (a few of the unenumerated "20+ more" may have lived in the extracted crates).

   What the findings actually are

   In accessibilitybot/src/analyzers/* the .expect() calls are overwhelmingly on compile-time-constant selectors/regexes, re-parsed on every call:

   let body_sel = Selector::parse("body").expect("valid selector");
   let re = Regex::new(r"(?i)font-size\s*:\s*(\d+)px").expect("valid regex");

   The error is genuinely impossible (the input is a string literal), but the scanner flags it because it sits in a per-document / per-file hot path.

   Recommended fix shape (two birds, one stone)

   Hoist each constant Selector::parse / Regex::new into a LazyLock (std, 1.80+) or once_cell::sync::Lazy static:

   static BODY_SEL: LazyLock<Selector> =
       LazyLock::new(|| Selector::parse("body").expect("static selector is valid"));

   This (a) removes the .expect() from the hot path per remediation option 1, and (b) stops recompiling the same selector/regex on every invocation — a perf win as well as the hygiene fix. The one remaining .expect() runs once at first use on a literal, which is the estate-sanctioned "impossible error" form.

   Note for whoever picks this up

   Do it from a fresh clone at current main, and verify with cargo clippy --workspace -- -W clippy::expect_used per the test plan. (A pre-#297 clone would re-vendor the now-deleted sustainabot files if pushed, so start clean.)

   ---

   Generated by Claude Code
2. hyperpolymath

   added

   tech-debtKnown shortcut, drift, or hygiene owed - includes cleanupKnown shortcut, drift, or hygiene owed - includes cleanup

   on Aug 27, 2026
3. hyperpolymath

   added

   priority:p2Normal - queue itNormal - queue it

   scope:repoConfined to this repositoryConfined to this repository

   status:readyFully specified and ready to be picked upFully specified and ready to be picked up

   on Sep 30, 2026