Skip to content

ci: model Cabal package-index readiness - #72

Merged
hyperpolymath merged 2 commits into
mainfrom
ci/cabal-index-evidence
Nov 2, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
ci/cabal-index-evidence

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

First regression case from game-server-admin run 41404909112. Model and fixtures need integration with the runner before this is an enforcing gate.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 56800612-bcdb-4b3a-9a03-470adec7f573
Commits

Reviewing files that changed from the base of the PR and between 24d34dc and cd17148.

Files selected for processing: 1
  • src/Assurance/Cabal.idr

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c56554d9-f696-40c6-89a5-f0f5c1269fed
Commits

Reviewing files that changed from the base of the PR and between 7f6ebcf and 24d34dc.

Files selected for processing: 1
  • src/Assurance/Cabal.idr

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 2
  • GitHub Check: CodeRabbit
  • GitHub Check: semgrep-cloud-platform/scan
Additional comments: 1
src/Assurance/Cabal.idr: 1

5-17: LGTM!

Summary

Summary by CodeRabbit

  • Builds
    • Online builds use the available package index when present.
    • If the index is missing or its status is unknown, the build refreshes it before resolving dependencies.

The change adds public types for Cabal index availability and online build plans. It adds planOnlineBuild, which selects Resolve when the index is available and RefreshThenResolve when the index is missing or unknown.

Changes: Online build planning

Layer / File(s) Summary
Index state and plan selection
src/Assurance/Cabal.idr
Adds IndexState and BuildPlan types. Adds planOnlineBuild to map Available to Resolve and Missing or Unknown to RefreshThenResolve.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · previous review 24d34

No actionable merge-blocking risk was identified in the scoped change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the main change: modelling Cabal package-index readiness in CI.
Description check Passed The description relates the changes to a regression case and explains that runner integration is still required before enforcement.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T07:28:48.150150Z 24d34dc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit de35c57 into main Nov 2, 2026
16 checks passed
@hyperpolymath
hyperpolymath deleted the ci/cabal-index-evidence branch November 2, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant