Remove windows server 2022 from ci#1319
Open
ludfjig wants to merge 1 commit intohyperlight-dev:mainfrom
Open
Conversation
ludfjig
added
area/infrastructure
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
requested review from
danbugs,
dblnz,
devigned,
jprendes,
marosset,
simongdavies and
syntactically
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Removes Windows Server 2022 from CI workflows and standardizes Windows CI to use the WS2025 Hyper-V runner selection.
Changes:
- Remove
hyperv(WS2022) from hypervisor matrices (PR validation, daily benchmarks, release benchmarks). - Update reusable workflow runner selection logic to only treat
hyperv-ws2025as Windows. - Switch the release Windows build job runner from
windows-2022towindows-2025and drop WS2022 benchmark artifacts from releases.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/dep_run_examples.yml | Updates runner label selection to no longer map hyperv to Windows/WS2022 pools. |
| .github/workflows/dep_build_test.yml | Same runner selection update for the build/test reusable workflow. |
| .github/workflows/dep_benchmarks.yml | Same runner selection update for the benchmarks reusable workflow. |
| .github/workflows/ValidatePullRequest.yml | Removes hyperv from PR validation matrix. |
| .github/workflows/DailyBenchmarks.yml | Removes hyperv from daily benchmarks matrix. |
| .github/workflows/CreateRelease.yml | Moves Windows release build runner to windows-2025 and removes WS2022 benchmark artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes windows server 2022 from CI. The main reason for doing so is that WS2022 does not support WHvResetPartition, which is an API we will start to rely on for windows.
Note that historic benchmarks show that 2022 is faster than 2025, for example benchmarks artifact from hyperlight release v0.13 show the following.
I'm not sure the reason for this. Doing some digging I am guessing that differences in building the images are probably the main cause for this. For 2022 we use
Azure Pipelines - Windows 2022which as far as I understand is based on https://github.com/actions/runner-images, whereas for 2025, we build our own from scratch based on2025-datacenter-g2. Some differences could be:Another thing to point out is that our 2022 runners use
Standard D8ads v5andStandard D8ds v5whereas 2025 usesStandard D16ads v5andStandard D16s v5, but I would not expect this to cause any such difference.It would be good to confirm these
Updated: Indeed the image was the main culprit as you can see below. The 2025 azure pipeline image is almost on part with perf compared to 2022