Allow ff tag annotations to be used with schema generation, outside SwggerGen#209
Merged
Allow ff tag annotations to be used with schema generation, outside SwggerGen#209
Conversation
…f SwaggerGen Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Context DB txn timeout, and interface to avoid connection leak during migration
EnriqueL8
reviewed
Mar 23, 2026
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Looks good - a few comments
Comment on lines
-354
to
-358
| (&SwaggerGen{ | ||
| options: &SwaggerGenOptions{ | ||
| PanicOnMissingDescription: true, | ||
| }, | ||
| }).Generate(context.Background(), []*Route{{ |
Contributor
There was a problem hiding this comment.
Feels like the expanded version was nicer to read
EnriqueL8
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where being able to use
openapi3gen.NewSchemaRefForValue()directly is very useful, but still exploiting all the value fromffstructetc. tags that have been documented onstructs via the FF-common framework.This PR also allows
ExportComponentOptsfromopenapi3gento be optionally specified in theSwaggerGenOptions