Skip to content

refactor: drop redundant continue and remove needless_continue allow - #4157

Open
MsfPablo wants to merge 1 commit into
hyperium:masterfrom
MsfPablo:fix/needless-continue
Open

refactor: drop redundant continue and remove needless_continue allow#4157
MsfPablo wants to merge 1 commit into
hyperium:masterfrom
MsfPablo:fix/needless-continue

Conversation

@MsfPablo

Copy link
Copy Markdown

Drops three needless continue expressions caught by clippy::needless_continue and removes the lint's allow entry from the project lint allowlist, advancing issue #4071.

Changes:

  • src/proto/h1/dispatch.rs: end of else branch in dispatch loop
  • src/proto/h2/upgrade.rs: empty-buffer arm in poll_read loop
  • src/proto/h2/client.rs: end of Poll::Ready(Some(...)) arm in dispatch loop
  • Cargo.toml: drop needless_continue = "allow"

Verification:

  • cargo clippy --features full -- -W clippy::needless_continue is clean
  • cargo build --features full succeeds
  • cargo test --features full --lib passes (115 passed, 0 failed)

Generated with Claude Code; I have read and reviewed every change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant