remove arithmetic_side_effects#4120
Open
yanns wants to merge 1 commit into
Open
Conversation
yanns
force-pushed
the
remove_arithmetic_side_effects
branch
from
3027a46 to
7a5ddd9
Compare
yanns
commented
Jun 27, 2026
| #[allow(clippy::arithmetic_side_effects)] | ||
| fn remaining(&self) -> usize { | ||
| debug_assert!( | ||
| self.capacity() >= self.filled, |
Author
There was a problem hiding this comment.
This should be true. We could use an assert! as in put_slice, but this would have some performance impact in release mode. I've opted for a debug_assert. Let me know if you think it's the right thing to do.
An alternative is to use saturating_sub which would have a performance cost.
yanns
force-pushed
the
remove_arithmetic_side_effects
branch
from
7a5ddd9 to
446fef5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #4071
In general, I've added quite a lot of
#[allow(clippy::arithmetic_side_effects)]. I still think that this lint is useful. It's easier to search for this and to review arithmetic operations. It can also prevent some issues in the future.There are some parts where I've used some saturating operations, which can have an impact of performance. This needs a careful review.
If this is too complex to review, I can remove the new saturating operations and add the
allowin those places. I could later open smaller PRs trying to address some of those.