Repository navigation
test: match the missing-parameter error case-insensitively - #142
Merged
Merged
Conversation
typos 1.51.1, which the GitHub Actions bump in #141 moves Spell Check to, reads the character class in `[Pp]arameter` as the misspelling `arameter`. `(?i)parameter` matches the same messages.
Deploying lance-csr with
|
| Latest commit: |
595a430
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://32cda2ea.lance-csr.pages.dev |
| Branch Preview URL: | https://test-typos-case-insensitive.lance-csr.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The GitHub Actions bump in #141 moves Spell Check from typos 1.26.0 to 1.51.1, and the newer dictionary fails on one line: it reads the character class in a test's
match="[Pp]arameter"as the misspellingarameter. Fixing it onmainlets Dependabot rebase #141 onto a passing base without hand edits to its branch.What changed
(?i)parameterinstead of[Pp]arameter. It accepts the same messages.Validation
typos1.51.1 and 1.26.0 both report nothing on the whole repository.make lintpasses locally. CI is pending.🤖 Generated with Claude Code