Add "extractionState": "manual" to every key by default#6
Open
adrianrl wants to merge 1 commit into
Open
Conversation
sebastianvarela
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When managing strings outside the project (our keys are generated and live in a
.xcstringsthat isn't extracted from source), Xcode raised a warning on every key:The fix is to set
"extractionState" : "manual"on each key. POEditor doesn't add this on export, sopoenow does it.Changes
download— marks every key asmanualafter normalizing placeholders. Done on the raw JSON tree (adds one field per entry, touches nothing else), so it's lossless: plurals and device variations survive untouched.StringCatalogserialization — defaultsextractionStatetomanualwhen a key doesn't already carry one. This meansdistribute,filterandremovealso guaranteemanualon write, so.xcstringsfiles already committed to a project get fixed the next time any command rewrites them — no full re-download required. An explicitextractionStatecoming from the input is still respected.Both paths are covered because our
filterflow merges the working tree onto a baseline (the catalog already in the repo, which predates this behaviour); relying ondownloadalone would leave the non-matching baseline keys warning forever.Tests
markingManualExtractionStatemarks every key and preserves pluralvariations; returns the input unchanged on invalid JSON.