fix(installer): stop auto-installing smbus broker service#88
Conversation
|
Warning Review limit reached
More reviews will be available in 57 minutes. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
HypercolorSmBusbroker during a per-machine install to prevent unprivileged interactive users from gaining unauthenticated access to privileged SMBus/MSR/SMN operations.Description
install-windows-smbus-service.ps1fromNSIS_HOOK_POSTINSTALLincrates/hypercolor-app/installer-hooks.nshand update the installer text to make broker setup an explicit administrator action while preserving the bundled PawnIO install and firewall rule additions.Testing
just checkbutjustis not available in this environment so no automated test run was performed; the change was validated by confirming the post-install hook no longer invokes the service installer and committing the patch.Codex Task