Skip to content

fix(installer): reject user-writable SMBus broker paths#86

Open
hyperb1iss wants to merge 1 commit into
mainfrom
codex/propose-fix-for-local-privilege-escalation-vulnerability
Open

fix(installer): reject user-writable SMBus broker paths#86
hyperb1iss wants to merge 1 commit into
mainfrom
codex/propose-fix-for-local-privilege-escalation-vulnerability

Conversation

@hyperb1iss
Copy link
Copy Markdown
Owner

Motivation

  • Prevent a local privilege-escalation vector where the SMBus broker service can be registered with a BinaryPathName that points into a user-writable (current-user) install tree, which would allow a low-privileged user to replace the broker binary and gain SYSTEM execution.

Description

  • Add Assert-ServiceBrokerPath to scripts/install-windows-smbus-service.ps1 (mirroring the existing PawnIO guard) and call it immediately after Resolve-SmbusBroker to reject broker executables located under %LOCALAPPDATA%, %APPDATA%, %USERPROFILE%, or C:\Users\* before creating the New-Service entry.

Testing

  • Attempted to run a PowerShell presence check with pwsh -NoLogo -NoProfile -Command "Get-Command pwsh | Out-Null", but pwsh is not installed in this Linux container so runtime script execution tests could not be performed; the change is minimal and follows the script's existing path-hardening pattern.

Codex Task

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Warning

Review limit reached

@hyperb1iss, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 13 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 650867f7-fd67-4c9a-89c6-4f265320ab0d

📥 Commits

Reviewing files that changed from the base of the PR and between 6f749b6 and 7e3133e.

📒 Files selected for processing (1)
  • scripts/install-windows-smbus-service.ps1
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/propose-fix-for-local-privilege-escalation-vulnerability

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant