fix(installer): reject user-writable SMBus broker paths#86
Conversation
|
Warning Review limit reached
More reviews will be available in 58 minutes and 13 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
BinaryPathNamethat points into a user-writable (current-user) install tree, which would allow a low-privileged user to replace the broker binary and gain SYSTEM execution.Description
Assert-ServiceBrokerPathtoscripts/install-windows-smbus-service.ps1(mirroring the existing PawnIO guard) and call it immediately afterResolve-SmbusBrokerto reject broker executables located under%LOCALAPPDATA%,%APPDATA%,%USERPROFILE%, orC:\Users\*before creating theNew-Serviceentry.Testing
pwsh -NoLogo -NoProfile -Command "Get-Command pwsh | Out-Null", butpwshis not installed in this Linux container so runtime script execution tests could not be performed; the change is minimal and follows the script's existing path-hardening pattern.Codex Task