Skip to content

Conversation

@stefgina
Copy link
Contributor

@stefgina stefgina commented Dec 24, 2025

What does this PR do?

hey, this PR fixes several small docstring issues in Qwen3-VL and adds a few clarifications:

  • correction for the videos argument description ("image" → "video") in Qwen3VLProcessor.__call__().
  • fixes various other typos in the processing & configuration files.
  • the description was wrong for image_token_id, video_token_id, and vision_start/end_token_id
    so I updated it to distinguish modality tokens from the vision segment delimiters properly.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@zucchini-nlp
@yonigozlan

@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: qwen3_vl

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zucchini-nlp zucchini-nlp enabled auto-merge (squash) January 5, 2026 11:52
@zucchini-nlp zucchini-nlp merged commit 37c9c94 into huggingface:main Jan 5, 2026
20 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants