Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
MekkCyber
left a comment
There was a problem hiding this comment.
A new backend! let's go 🔥
kernels/src/kernels/utils.py
Outdated
| Build vaariant for arch kernels, returns `None` when the backend | ||
| does not (yet) support arch kernels. |
There was a problem hiding this comment.
| Build vaariant for arch kernels, returns `None` when the backend | |
| does not (yet) support arch kernels. | |
| Build variant for arch kernels, returns `None` when the backend | |
| does not (yet) support arch kernels. |
|
Putting this in draft for a bit, the Neuron detection code needs te be changed. |
JingyaHuang
left a comment
There was a problem hiding this comment.
thx for taking care of this! look good to me, except for the coming transition from torch xla. also wondering if you plan to add a ci with trn2 runner.
Hooking up CI would be great! |
drbh
left a comment
There was a problem hiding this comment.
looks good to me! exciting to add another backend
kernels/src/kernels/utils.py
Outdated
| def _build_variant(backend: str | None) -> str: | ||
| def _build_variant(backend: str | None) -> str | None: | ||
| """ | ||
| Build vaariant for arch kernels, returns `None` when the backend |
MekkCyber
left a comment
There was a problem hiding this comment.
Very cool to see this land !
This change add support for Torch Neuron and NKI to the
kernelsPython package. Support for builder is not added in this change.