Repository navigation
[ci] fix compilation CI. #15092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+67
−13
Merged
[ci] fix compilation CI. #15092
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6b86d99
fix compilation CI.
sayakpaul 550535a
resolve conflicts.
sayakpaul e69d60f
Merge branch 'main' into ci-compile-fix
sayakpaul d016c35
Merge branch 'main' into ci-compile-fix
sayakpaul ec16212
Merge branch 'main' into ci-compile-fix
sayakpaul 053e1a6
fix attentionbackend name dispatch.
sayakpaul 0cf0576
skip with a marker.
sayakpaul bc4d439
Merge branch 'main' into ci-compile-fix
sayakpaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,10 +60,11 @@ def get_init_dict(self) -> dict: | |
| "out_visual_dim": 8, | ||
| "time_dim": 16, | ||
| "patch_size": (1, 2, 2), | ||
| "model_dim": 24, | ||
| "model_dim": 32, | ||
| "ff_dim": 32, | ||
| "num_visual_blocks": 2, | ||
| "axes_dims": (4, 4, 4), | ||
| # head_dim = sum(axes_dims); Inductor lowers flex attention only for head dims of at least 16 | ||
| "axes_dims": (4, 6, 6), | ||
| } | ||
|
|
||
| def _build_dummy_inputs(self, batch_size: int, num_frames: int, height: int, width: int) -> dict: | ||
|
|
@@ -106,6 +107,17 @@ def different_shapes_for_compilation(self): | |
| def get_dummy_inputs(self, height: int = 16, width: int = 16) -> dict: | ||
| return self._build_dummy_inputs(batch_size=1, num_frames=2, height=height, width=width) | ||
|
|
||
| @pytest.mark.xfail( | ||
| reason=( | ||
| "The token grid is split into 8x8 blocks and `sliding_tile_mask` sizes its table by `max(...)` of the block " | ||
| "counts, so the compiled graph specializes on the input shape and recompiles." | ||
| ), | ||
| raises=torch._dynamo.exc.RecompileError, | ||
| strict=True, | ||
| ) | ||
| def test_compile_on_different_shapes(self): | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can make it work with some modeling-level changes but not a priority for this model at the moment IMO. |
||
| super().test_compile_on_different_shapes() | ||
|
|
||
|
|
||
| @pytest.mark.skipif(torch_device == "cpu", reason="FlexAttention does not support backward on CPU.") | ||
| class TestKandinsky6SRTransformerTraining(Kandinsky6SRTransformerTesterConfig, TrainingTesterMixin): | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To satisfy the requirements of Flex + compile.