Skip to content

[tests] fix hiding of hf hub request failures. #14690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sayakpaul wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[tests] fix hiding of hf hub request failures. #14690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ad678d
fix hiding of hf hub request failures.
sayakpaul Sep 2, 2026
26e37e4
Merge branch 'main' into handle-test_variant_sharded_ckpt_legacy_form…
sayakpaul Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions tests/models/test_modeling_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,12 @@ def load_model(path):
kwargs["subfolder"] = subfolder
return UNet2DConditionModel.from_pretrained(path, **kwargs)

# Download outside of `pytest.warns` so that a Hub hiccup surfaces as the network error it is,
# instead of a misleading "DID NOT WARN".
path = snapshot_download(repo_id=repo_id) if use_local else repo_id

with pytest.warns(FutureWarning) as warning:
if use_local:
with tempfile.TemporaryDirectory() as tmpdirname:
tmpdirname = snapshot_download(repo_id=repo_id)
_ = load_model(tmpdirname)
else:
_ = load_model(repo_id)
_ = load_model(path)

warning_messages = " ".join(str(w.message) for w in warning)
assert "This serialization format is now deprecated to standardize the serialization" in warning_messages
Expand Down
Loading