Skip to content

[tests] remove test_pipelines_common.py - #14669

Open
sayakpaul wants to merge 9 commits into
mainfrom
remove-test-pipelines-common
Open

[tests] remove test_pipelines_common.py#14669
sayakpaul wants to merge 9 commits into
mainfrom
remove-test-pipelines-common

Conversation

@sayakpaul

@sayakpaul sayakpaul commented Sep 1, 2026

Copy link
Copy Markdown
Member
  • Move FluxIPAdapterTesterMixin to the IP Adapter testing utils since it's shared by more than Flux.
  • Migrate old imports in the test suites of DeepFloyd IF, etc. to use new ones.
  • Migrate the Stable Diffusion Adapter test suite to use new mixins.
  • Remove test_pipelines_common.py.

@github-actions github-actions Bot added tests size/L PR with diff > 200 LOC labels Sep 1, 2026
# support `"pt"`; adding that here is a `src/` change and out of scope for this test migration, so the affected
# tests are marked `xfail` rather than skipped: whoever adds the `"pt"` branch will see them XPASS and can drop
# these markers.
NO_PT_OUTPUT = pytest.mark.xfail(

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to other ideas but I chose to xfail these tests and not introduce anything really new to our shared tester mixins.

@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/stable_diffusion_adapter/test_stable_diffusion_adapter.py

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

pytest tests/pipelines/stable_diffusion_adapter/test_stable_diffusion_adapter.py passed on GPU — view logs.

Comment thread tests/pipelines/testing_utils/memory.py Outdated
return self.get_pipeline()

def enable_group_offload_on_component(pipe, group_offloading_kwargs):
offloaded_component_names = set()

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# `transformer`/`unet`/`controlnet`/`adapter`, and only puts `vae`/`vqvae`/`image_encoder` back on the accelerator.
# A prior pipeline's denoiser is called `prior`, so it matches neither list and is left on CPU while the text
# encoder is onloaded. Fixing this means widening the mixin's component lists, not changing the pipeline.
COMPONENT_GROUP_OFFLOAD_XFAIL_REASON = (

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side effect of fixes in tests/pipelines/testing_utils/memory.py.

@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

⚠️ pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference was cancelled on GPU — view logs.

@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/consisid/test_consisid.py tests/pipelines/stable_audio/test_stable_audio.py

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

pytest tests/pipelines/consisid/test_consisid.py tests/pipelines/stable_audio/test_stable_audio.py passed on GPU — view logs.

@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference passed on GPU — view logs.

@github-actions github-actions Bot added the CI label Sep 1, 2026
pytest -n 1 --max-worker-restart=0 --dist=loadfile \
--make-reports=tests_torch_minimum_version_cuda \
tests/models/test_modeling_common.py \
tests/pipelines/test_pipelines_common.py \

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer exists.

Comment on lines -17 to +19
- "tests/pipelines/test_pipelines_common.py"
- "tests/pipelines/testing_utils/**.py"
- "tests/models/test_modeling_common.py"
- "tests/models/testing_utils/**.py"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To have parity in our CI when test changes happen.

pytest -n 1 --max-worker-restart=0 --dist=loadfile \
--make-reports=tests_torch_minimum_cuda \
tests/models/test_modeling_common.py \
tests/pipelines/test_pipelines_common.py \

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer exist.

)


class AdapterPipelineTesterConfig(BasePipelineTesterConfig):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining test suite being refactored.

@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/kandinsky/ tests/pipelines/kandinsky2_2/

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

pytest tests/pipelines/kandinsky/ tests/pipelines/kandinsky2_2/ passed on GPU — view logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI size/L PR with diff > 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant