Skip to content

refactor wan pipeline tests to the new mixin structure#14224

Open
akshan-main wants to merge 4 commits into
huggingface:mainfrom
akshan-main:refactor-wan-pipeline-tests
Open

refactor wan pipeline tests to the new mixin structure#14224
akshan-main wants to merge 4 commits into
huggingface:mainfrom
akshan-main:refactor-wan-pipeline-tests

Conversation

@akshan-main

@akshan-main akshan-main commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Refactors the wan pipeline tests to the new mixin structure from #14113: a WanPipelineTesterConfig plus TestWanPipeline(PipelineTesterMixin) and TestWanPipelineMemory(MemoryTesterMixin), with the integration tests moved to a pytest slow class.

Existing coverage is kept: test_inference and test_save_load_optional_components, the latter overridden to null only transformer_2 since _optional_components also lists the required transformer. No caching tests are added since the old suite had none, and the attention-slicing test is dropped as the new framework has no equivalent.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you read our philosophy doc (important for complex PRs)?
  • Was this discussed/approved via a GitHub issue or the forum? Discussed on Slack with @sayakpaul
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@sayakpaul

@github-actions github-actions Bot added size/M PR with diff < 200 LOC tests and removed size/M PR with diff < 200 LOC labels Jul 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi @akshan-main, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Fixes #1234) to the PR description so the issue is linked. See the contribution guide for more details. If this PR intentionally does not fix a tracked issue, a maintainer can add the no-issue-needed label to silence this reminder.

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Comment thread tests/pipelines/wan/test_wan.py Outdated
Comment on lines +30 to +34
from ..testing_utils import (
BasePipelineTesterConfig,
MemoryTesterMixin,
PipelineTesterMixin,
)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from ..testing_utils import (
BasePipelineTesterConfig,
MemoryTesterMixin,
PipelineTesterMixin,
)
from ..testing_utils import (
BasePipelineTesterConfig MemoryTesterMixin, PipelineTesterMixin
)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions github-actions Bot added the size/M PR with diff < 200 LOC label Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M PR with diff < 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants