Skip to content

add PR fork workable#13438

Open
paulinebm wants to merge 3 commits intomainfrom
fix-review
Open

add PR fork workable#13438
paulinebm wants to merge 3 commits intomainfrom
fix-review

Conversation

@paulinebm
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot added CI size/M PR with diff < 200 LOC labels Apr 9, 2026
@github-actions github-actions bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 9, 2026
@github-actions github-actions bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 9, 2026
Copy link
Copy Markdown
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. LMK if they are clear.

)
concurrency:
group: claude-review-${{ github.event.issue.number || github.event.pull_request.number }}
cancel-in-progress: true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to cancel a run that's in progress? Probably not because Claude can provide useful feedback on the first PR and that is also how we would often use it to do a review.

DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
run: |
# Preserve main's CLAUDE.md before any fork checkout
cp CLAUDE.md /tmp/main-claude.md 2>/dev/null || touch /tmp/main-claude.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a copy of everything under .ai from main because the review-rules.md references some files from the files present under .ai?

Comment on lines +129 to +130
"Bash(git commit*)",
"Bash(git push*)",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be able to commit specific rules to the rule file, actually:

1. NEVER modify, create, or delete files — unless the human comment contains verbatim:
               COMMIT THIS (uppercase). If committing, only touch src/diffusers/ and .ai/.

How do we tackle that with this denial?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI size/M PR with diff < 200 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants