Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Just a comment on re-installing test related deps given we already install them:
| - name: Install dependencies | ||
| run: | | ||
| uv pip install -e ".[quality]" | ||
| uv pip install -e ".[quality,test]" |
There was a problem hiding this comment.
What's happening here?
We already do it right?
There was a problem hiding this comment.
Fine to remove, but we'd have to merge just the changes to setup.py with the CI on this PR failing and then run a build and push up the images.
Thought it would be better just remove in a follow up.
| - name: Install dependencies | ||
| run: | | ||
| uv pip install -e ".[quality]" | ||
| uv pip install -e ".[quality,test]" |
| - name: Install dependencies | ||
| run: | | ||
| uv pip install -e ".[quality]" | ||
| uv pip install -e ".[quality,test]" |
There was a problem hiding this comment.
Should this change also be added to the push workflows such as push_tests.yml? For example here:
diffusers/.github/workflows/push_tests.yml
Line 134 in 42f8cbb
There was a problem hiding this comment.
So the reason it's here is to just verify everything is passing. We install test deps when building the Docker images.
Will remove this from the workflow once setup.py is merged to main and we push up the new images.
4 participants
What does this PR do?
We had
k-diffusionas a test dependency, which in turn installedclip-anytorchwhich hadftfyas a dependency. This is why all the tests with pipelines usingftfywere passing even though we never had it in our test deps.We removed
k-diffusionfrom the library since it's no longer maintained and this resulted inftfyalso getting inadvertently removed.Adding it back here as a test dep.
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.