[CI] Revert setuptools CI Fix as the Failing Pipelines are Deprecated#13149
Open
[CI] Revert setuptools CI Fix as the Failing Pipelines are Deprecated#13149
setuptools CI Fix as the Failing Pipelines are Deprecated#13149Conversation
Collaborator
Author
|
Ran the
From a previous CI run with the error (https://github.com/huggingface/diffusers/actions/runs/21981663925/job/63505654736?pr=12524) it looks like it's still being used in |
Member
|
We should consider deprecating it and removing it from testing IMO like these: |
Collaborator
|
The pipelines are deprecated. Let's remove it. Opened a PR #13152 |
setuptools Version for Dependencies Which Depend on pkg_resourcessetuptools CI Fix as the Failing Pipelines are Deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #13129 and #13132 which maybe finally fixes the
ModuleNotFoundError: No module named 'pkg_resources'CI error.I think the previous fix didn't work because I assumed the error was triggered when installing the packages with the issue (such as
k-diffusion), but I think the error actually happens at runtime when we try to import from the packages. This is because theclip-anytorchdependency ofk-diffusionwill attempt to explicitly importpkg_resourcesinsetup.py:https://github.com/rom1504/CLIP/blob/4610075309864ea7aaec976c58ccd69048b64c1e/setup.py#L3
So I think the solution is to pin
setuptoolsto a version which still haspkg_resourcesso that the import succeeds.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul
@DN6