Skip to content

[CI] Revert setuptools CI Fix as the Failing Pipelines are Deprecated#13149

Open
dg845 wants to merge 3 commits intomainfrom
ci-pin-setuptools-pkg-resources
Open

[CI] Revert setuptools CI Fix as the Failing Pipelines are Deprecated#13149
dg845 wants to merge 3 commits intomainfrom
ci-pin-setuptools-pkg-resources

Conversation

@dg845
Copy link
Collaborator

@dg845 dg845 commented Feb 16, 2026

What does this PR do?

Follow-up to #13129 and #13132 which maybe finally fixes the ModuleNotFoundError: No module named 'pkg_resources' CI error.

I think the previous fix didn't work because I assumed the error was triggered when installing the packages with the issue (such as k-diffusion), but I think the error actually happens at runtime when we try to import from the packages. This is because the clip-anytorch dependency of k-diffusion will attempt to explicitly import pkg_resources in setup.py:

https://github.com/rom1504/CLIP/blob/4610075309864ea7aaec976c58ccd69048b64c1e/setup.py#L3

So I think the solution is to pin setuptools to a version which still has pkg_resources so that the import succeeds.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sayakpaul
@DN6

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a bummer! Is k_diffusion still used?

Should we consider fully deprecating it? @DN6

@dg845
Copy link
Collaborator Author

dg845 commented Feb 16, 2026

Ran the pr_tests_gpu.yml workflow manually (https://github.com/huggingface/diffusers/actions/runs/22047985704) and it looks like the issue is fixed: https://github.com/huggingface/diffusers/actions/runs/22047985704/job/63700281914

Is k_diffusion still used?

From a previous CI run with the error (https://github.com/huggingface/diffusers/actions/runs/21981663925/job/63505654736?pr=12524) it looks like it's still being used in diffusers.pipelines.stable_diffusion_k_diffusion.pipeline_stable_diffusion_k_diffusion.

@sayakpaul
Copy link
Member

We should consider deprecating it and removing it from testing IMO like these:
https://huggingface.co/docs/diffusers/main/en/api/pipelines/attend_and_excite

@DN6
Copy link
Collaborator

DN6 commented Feb 16, 2026

The pipelines are deprecated. Let's remove it. Opened a PR #13152

@dg845 dg845 changed the title [CI] Pin setuptools Version for Dependencies Which Depend on pkg_resources [CI] Revert setuptools CI Fix as the Failing Pipelines are Deprecated Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants