Open
Conversation
Add setName, setNotificationSetting, setPermission, and setParentTeamId methods following the existing setDescription and setPrivacy pattern. Each uses PATCH to the team API endpoint. Fixes hub4j#2218
rozza-sb
reviewed
Apr 10, 2026
rozza-sb
left a comment
rozza-sb
left a comment
There was a problem hiding this comment.
Some notes on notifications and permissions
| * @throws IOException | ||
| * the io exception | ||
| */ | ||
| public void setNotificationSetting(String notificationSetting) throws IOException { |
There was a problem hiding this comment.
Looking at GHTeamBuilder, this doesn't already exist in this repo as a concept under a team. However, I think this would work better as an enum so that we can only provide valid values to the request
| * @throws IOException | ||
| * the io exception | ||
| */ | ||
| public void setPermission(String permission) throws IOException { |
There was a problem hiding this comment.
GHOrganization.Permission exists for this already, so should be reused here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHTeam currently only has
setDescriptionandsetPrivacy. The GitHub API supports updating several more properties.This adds 4 missing setters, all following the same PATCH pattern as the existing ones:
setName(String name)setNotificationSetting(String notificationSetting)setPermission(String permission)setParentTeamId(Long parentTeamId)(nullable, to support removing parent)Each is a single PATCH call to the team endpoint. An atomic multi-property update builder could follow as a separate enhancement if maintainers want one.
Fixes #2218
This contribution was developed with AI assistance (Codex).