Open
Conversation
Design GitHubJackson interface with methods for reading/writing JSON Implement GitHubJackson2 and GitHubJackson3 Create DefaultGitHubJackson factory with programmatic selection Create GitHubJacksonException wrapper classes Add GitHubBuilder.withJackson() for configuring Jackson implementation Add testing infrastructure for both Jackson versions
bitwiseman
reviewed
Jan 26, 2026
bitwiseman
reviewed
Jan 27, 2026
bitwiseman
reviewed
Jan 27, 2026
bitwiseman
reviewed
Jan 27, 2026
bitwiseman
reviewed
Jan 27, 2026
src/main/java/org/kohsuke/github/internal/DefaultGitHubJackson.java
Outdated
Show resolved
Hide resolved
bitwiseman
reviewed
Feb 4, 2026
| * maintain backward compatibility with code that expects Jackson 2.x ObjectReader/ObjectWriter. | ||
| * </p> | ||
| */ | ||
| private static final GitHubJackson2 JACKSON2_STATIC = new GitHubJackson2(); |
Member
There was a problem hiding this comment.
Suggested change
| private static final GitHubJackson2 JACKSON2_STATIC = new GitHubJackson2(); | |
| private static final GitHubJackson2 JACKSON_STATIC = new DefaultGitHubJackson.createDefault(); |
Contributor
Author
There was a problem hiding this comment.
The JACKSON2_STATIC field is intentionally typed as GitHubJackson2 because it's used by the static methods getMappingObjectReader() and getMappingObjectWriter() which return Jackson 2.x specific types (com.fasterxml.jackson.databind.ObjectReader/ObjectWriter).
If we change this to use DefaultGitHubJackson.createDefault(), it would return GitHubJackson3 when Jackson 3 is available, which would break these methods since they need Jackson 2.x types.
Should we:
- Keep JACKSON2_STATIC as-is for backward compatibility with these static methods?
- Deprecate these Jackson 2.x specific static methods?
- Something else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #2173 for the initial PR and associated discussion.
This PR is the follow-up of #2182.
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"locally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: